From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51140)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XJP3r-00051j-KR
	for qemu-devel@nongnu.org; Mon, 18 Aug 2014 11:41:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XJP3k-0003JI-Sg
	for qemu-devel@nongnu.org; Mon, 18 Aug 2014 11:41:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33290)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XJP3k-0003J8-Jt
	for qemu-devel@nongnu.org; Mon, 18 Aug 2014 11:41:24 -0400
Message-ID: <53F21E9B.2080901@redhat.com>
Date: Mon, 18 Aug 2014 17:41:15 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1407809575-24576-1-git-send-email-famz@redhat.com>
In-Reply-To: <1407809575-24576-1-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 0/2] scsi: Change device init to realize
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, armbru@redhat.com, stefanha@redhat.com, afaerber@suse.de

Il 12/08/2014 04:12, Fam Zheng ha scritto:
> v4: Add Andreas' and Stefan's rev-by for patch 1.
>     Retain the error message in patch 2.
> 
> DeviceClass->init is the old interface, let's convert scsi devices to the new
> ->realize API.
> 
> A user visible change is the error message shown in qemu-iotests reference
> output, but only redundant error messages dropped.
> 
> Fam
> 
> 
> Fam Zheng (2):
>   block: Pass errp in blkconf_geometry
>   scsi-bus: Convert DeviceClass init to realize
> 
>  hw/block/block.c           | 18 +++++-----
>  hw/block/virtio-blk.c      |  7 ++--
>  hw/ide/qdev.c              | 11 ++++--
>  hw/scsi/lsi53c895a.c       |  1 +
>  hw/scsi/scsi-bus.c         | 70 +++++++++++++++++++-------------------
>  hw/scsi/scsi-disk.c        | 83 +++++++++++++++++++++++++---------------------
>  hw/scsi/scsi-generic.c     | 37 ++++++++++-----------
>  include/hw/block/block.h   |  6 ++--
>  include/hw/scsi/scsi.h     |  7 ++--
>  tests/qemu-iotests/051.out |  2 --
>  10 files changed, 127 insertions(+), 115 deletions(-)
> 

Thanks, applying this to scsi-next.

Paolo