From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJQG8-0003gA-17 for qemu-devel@nongnu.org; Mon, 18 Aug 2014 12:58:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XJQG1-00018G-OM for qemu-devel@nongnu.org; Mon, 18 Aug 2014 12:58:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37312) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJQG1-000182-FN for qemu-devel@nongnu.org; Mon, 18 Aug 2014 12:58:09 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7IGw8An017021 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 18 Aug 2014 12:58:08 -0400 Message-ID: <53F2309C.7020002@redhat.com> Date: Mon, 18 Aug 2014 18:58:04 +0200 From: Max Reitz MIME-Version: 1.0 References: <1408378243-19713-1-git-send-email-armbru@redhat.com> <1408378243-19713-5-git-send-email-armbru@redhat.com> In-Reply-To: <1408378243-19713-5-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 4/4] block: Drop some superfluous casts from void * List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com On 18.08.2014 18:10, Markus Armbruster wrote: > They clutter the code. Unfortunately, I can't figure out how to make > Coccinelle drop all of them, so I have to settle for common special > cases: > > @@ > type T; > T *pt; > void *pv; > @@ > - pt = (T *)pv; > + pt = pv; > @@ > type T; > @@ > - (T *) > (\(g_malloc\|g_malloc0\|g_realloc\|g_new\|g_new0\|g_renew\| > g_try_malloc\|g_try_malloc0\|g_try_realloc\| > g_try_new\|g_try_new0\|g_try_renew\)(...)) > > Signed-off-by: Markus Armbruster > --- > block/vhdx-log.c | 2 +- > block/vvfat.c | 8 ++++---- > hw/ide/microdrive.c | 2 +- > 3 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/block/vhdx-log.c b/block/vhdx-log.c > index eb5c7a0..4267e60 100644 > --- a/block/vhdx-log.c > +++ b/block/vhdx-log.c > @@ -923,7 +923,7 @@ static int vhdx_log_write(BlockDriverState *bs, BDRVVHDXState *s, > buffer = qemu_blockalign(bs, total_length); > memcpy(buffer, &new_hdr, sizeof(new_hdr)); > > - new_desc = (VHDXLogDescriptor *) (buffer + sizeof(new_hdr)); > + new_desc = (buffer + sizeof(new_hdr)); > data_sector = buffer + (desc_sectors * VHDX_LOG_SECTOR_SIZE); > data_tmp = data; You could drop the parantheses here. Also, I still don't like void pointer arithmetic, but well... ;-) Reviewed-by: Max Reitz