qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Amit Shah <amit.shah@redhat.com>, Markus Armbruster <armbru@redhat.com>
Cc: Amos Kong <akong@redhat.com>, qemu list <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 0/2] virtio-serial: Prevent addition of ports with same name
Date: Mon, 18 Aug 2014 19:17:42 +0200	[thread overview]
Message-ID: <53F23536.2070405@suse.de> (raw)
In-Reply-To: <20140818171058.GB31856@grmbl.mre>

Am 18.08.2014 19:10, schrieb Amit Shah:
> On (Wed) 06 Aug 2014 [09:27:04], Markus Armbruster wrote:
>> Amit Shah <amit.shah@redhat.com> writes:
>>
>>> Hi,
>>>
>>> The 2nd patch prevents adding ports to the system with conflicts in
>>> the 'name' parameter.  This is done by going through all the ports in
>>> the system, including ports on other virtio-serial devices.
>>>
>>> The first patch prepares for this by creating a linked list of all
>>> available virtio-serial devices, so they can be walked over to check
>>> their ports' names.
>>>
>>> Please review.
>>
>> No advice from Andreas on better ways to iterate over devices, yet
>> (vacation time?).  If there is one, we can always use it on top.

I'm not aware of such a question. Context?

> Couple of weeks later, no other responses, so will send a pull req.

If you have a question, ask me on #qemu or put it on the call agenda.
It's hopeless waiting for me to catch up with my old unread mail as new
ones keep coming in.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

      reply	other threads:[~2014-08-18 17:18 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-16 11:31 [Qemu-devel] [PATCH 0/2] virtio-serial: Prevent addition of ports with same name Amit Shah
2014-07-16 11:31 ` [Qemu-devel] [PATCH 1/2] virtio-serial: create a linked list of all active devices Amit Shah
2014-08-04 11:33   ` Markus Armbruster
2014-08-04 11:45     ` Amit Shah
2014-08-06  7:27       ` Markus Armbruster
2014-08-06  7:39         ` Amit Shah
2014-08-18 17:21       ` Andreas Färber
2014-08-19 15:45         ` Markus Armbruster
2014-08-19 16:15           ` Andreas Färber
2014-07-16 11:31 ` [Qemu-devel] [PATCH 2/2] virtio-serial: search for duplicate port names before adding new ports Amit Shah
2014-08-06  7:27 ` [Qemu-devel] [PATCH 0/2] virtio-serial: Prevent addition of ports with same name Markus Armbruster
2014-08-06  7:39   ` Amit Shah
2014-08-18 17:10   ` Amit Shah
2014-08-18 17:17     ` Andreas Färber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F23536.2070405@suse.de \
    --to=afaerber@suse.de \
    --cc=akong@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).