From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48193) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJTTk-0002gJ-Jp for qemu-devel@nongnu.org; Mon, 18 Aug 2014 16:24:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XJTTc-0001wq-Lo for qemu-devel@nongnu.org; Mon, 18 Aug 2014 16:24:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62977) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJTTc-0001wa-E9 for qemu-devel@nongnu.org; Mon, 18 Aug 2014 16:24:24 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7IKON4Z015647 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 18 Aug 2014 16:24:24 -0400 Message-ID: <53F260F0.6000805@redhat.com> Date: Mon, 18 Aug 2014 22:24:16 +0200 From: Max Reitz MIME-Version: 1.0 References: <1408392029-29531-1-git-send-email-mreitz@redhat.com> <1408392029-29531-4-git-send-email-mreitz@redhat.com> <53F25FAC.9050902@redhat.com> In-Reply-To: <53F25FAC.9050902@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] qcow2: Add runtime options for cache sizes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi On 18.08.2014 22:18, Eric Blake wrote: > On 08/18/2014 02:00 PM, Max Reitz wrote: >> Add options for specifying the size of the metadata caches. This can >> either be done directly for each cache (if only one is given, the other >> will be derived according to a default ratio) or combined for both. >> >> Signed-off-by: Max Reitz >> --- >> block/qcow2.c | 112 +++++++++++++++++++++++++++++++++++++++++++++++++++------- >> block/qcow2.h | 3 ++ >> 2 files changed, 103 insertions(+), 12 deletions(-) > I would suspect that you need to also modify qapi/block-core.json to > document the new QMP parameters that can be tuned when hot-plugging a > qcow2 disk. Oh, you're right - that structure is missing all of the corruption detection parameters as well. I'll prepare a follow-up patch tomorrow. Max