From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48371) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJYS9-00085B-1Q for qemu-devel@nongnu.org; Mon, 18 Aug 2014 21:43:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XJYS3-000288-Uv for qemu-devel@nongnu.org; Mon, 18 Aug 2014 21:43:12 -0400 Received: from [59.151.112.132] (port=30521 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJYS3-00027f-Jl for qemu-devel@nongnu.org; Mon, 18 Aug 2014 21:43:07 -0400 Message-ID: <53F2A8A1.8030607@cn.fujitsu.com> Date: Tue, 19 Aug 2014 09:30:09 +0800 From: Gu Zheng MIME-Version: 1.0 References: <1407387248-14850-1-git-send-email-guz.fnst@cn.fujitsu.com> In-Reply-To: <1407387248-14850-1-git-send-email-guz.fnst@cn.fujitsu.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH 00/10] cpu: add device_add foo-x86_64-cpu and i386 cpu hot remove support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gu Zheng Cc: qemu-devel@nongnu.org, tangchen@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, anshul.makkar@profitbricks.com, chen.fan.fnst@cn.fujitsu.com, imammedo@redhat.com, afaerber@suse.de Hi Igor, Andreas, Could you please help to review this series? Any comment is welcome. Regards, Gu On 08/07/2014 12:53 PM, Gu Zheng wrote: > This series is based on the previous patchset from Chen Fan: > https://lists.nongnu.org/archive/html/qemu-devel/2014-05/msg02360.html > https://lists.nongnu.org/archive/html/qemu-devel/2013-12/msg04266.html >=20 > Patch 1~3: add device_add foo-x86_64-cpu support > These three patches try to make cpu hotplug with device_add, and make > "-device foo-x86_64-cpu" available=EF=BC=8Calso we can set apic-id > property with command line, if without setting apic-id property, > we offer the first unoccupied apic id as the default new apic id. > When hotplug cpu with device_add, additional check of APIC ID will be > done after cpu object initialization which was different from > 'cpu_add' command that check 'ids' at the beginning. >=20 > Patch 4~10: add i386 cpu hot remove support > Via implementing ACPI standard methods _EJ0 in ACPI table, after Guest > OS remove one vCPU online, the fireware will store removed bitmap to > QEMU, then QEMU could know to notify the assigned vCPU of exiting. > Meanwhile, intruduce the QOM command 'device_del' to remove vCPU from > QEMU itself. >=20 > Chen Fan (6): > cpu: introduce CpuTopoInfo structure for argument simplification > cpu: add device_add foo-x86_64-cpu support > x86: add x86_cpu_unrealizefn() for cpu apic remove > qom cpu: rename variable 'cpu_added_notifier' to > 'cpu_hotplug_notifier' > i386: implement pc interface cpu_common_unrealizefn() in qom/cpu.c > cpu hotplug: implement function cpu_status_write() for vcpu ejection >=20 > Gu Zheng (4): > qom/cpu: move register_vmstate to common CPUClass.realizefn > i386: add cpu device_del support > qom cpu: add UNPLUG cpu notify support > cpus: reclaim allocated vCPU objects >=20 > cpus.c | 44 ++++++++++++ > exec.c | 32 +++++---- > hw/acpi/cpu_hotplug.c | 55 +++++++++++++-- > hw/acpi/ich9.c | 13 ++-- > hw/acpi/piix4.c | 21 +++--- > hw/i386/acpi-dsdt-cpu-hotplug.dsl | 6 ++- > hw/i386/kvm/apic.c | 8 ++ > hw/i386/pc.c | 2 +- > hw/intc/apic.c | 10 +++ > hw/intc/apic_common.c | 26 ++++++- > include/hw/acpi/cpu_hotplug.h | 14 ++++- > include/hw/acpi/ich9.h | 2 +- > include/hw/cpu/icc_bus.h | 1 + > include/hw/i386/apic_internal.h | 3 + > include/qom/cpu.h | 12 +++ > include/sysemu/kvm.h | 1 + > include/sysemu/sysemu.h | 2 +- > kvm-all.c | 57 +++++++++++++++- > qdev-monitor.c | 1 + > qom/cpu.c | 29 +++++++-- > target-i386/cpu-qom.h | 1 + > target-i386/cpu.c | 138 +++++++++++++++++++++++++++++++= +++++- > target-i386/topology.h | 51 +++++++++---- > 23 files changed, 464 insertions(+), 65 deletions(-) >=20