From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57666) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJZRX-0004qY-Ne for qemu-devel@nongnu.org; Mon, 18 Aug 2014 22:46:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XJZRR-0002kO-66 for qemu-devel@nongnu.org; Mon, 18 Aug 2014 22:46:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39790) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJZRQ-0002k7-UL for qemu-devel@nongnu.org; Mon, 18 Aug 2014 22:46:33 -0400 Message-ID: <53F2BA7F.20001@redhat.com> Date: Tue, 19 Aug 2014 10:46:23 +0800 From: Jason Wang MIME-Version: 1.0 References: <1408355491-42089-1-git-send-email-jasowang@redhat.com> <53F1ED7A.5060900@huawei.com> In-Reply-To: <53F1ED7A.5060900@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vhost_net: start/stop guest notifiers properly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Zhangjie (HZ)" , mst@redhat.com, qemu-devel@nongnu.org On 08/18/2014 08:11 PM, Zhangjie (HZ) wrote: > On 2014/8/18 17:51, Jason Wang wrote: >> commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue >> support changed the order of stopping the device. Previously >> vhost_dev_stop would disable backend and only afterwards, unset guest >> notifiers. We now unset guest notifiers while vhost is still >> active. This can lose interrupts causing guest networking to fail. >> >> Additionally, remove the hdev->started assert in vhost.c since we may >> want to start the guest notifiers before vhost starts and stop the >> guest notifiers after vhost is stopped. >> >> In particular, this has been observed during migration. > Thanks! I will have a test about your patch today! :-) The patch was reported not applied cleanly. I will rebase it and send a new one. Please test that patch. Thanks.