From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57863)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1XJZTO-0005lf-C3
	for qemu-devel@nongnu.org; Mon, 18 Aug 2014 22:48:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1XJZTI-0003Ai-23
	for qemu-devel@nongnu.org; Mon, 18 Aug 2014 22:48:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37111)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1XJZTH-0003Ad-Qk
	for qemu-devel@nongnu.org; Mon, 18 Aug 2014 22:48:27 -0400
Message-ID: <53F2BAF1.7050101@redhat.com>
Date: Tue, 19 Aug 2014 10:48:17 +0800
From: Jason Wang <jasowang@redhat.com>
MIME-Version: 1.0
References: <1408355491-42089-1-git-send-email-jasowang@redhat.com>
	<CAJ75kXaXvfq78PaccDVo2bA4k5f7G7rUP=rrXjj=TpgJyL+eEQ@mail.gmail.com>
In-Reply-To: <CAJ75kXaXvfq78PaccDVo2bA4k5f7G7rUP=rrXjj=TpgJyL+eEQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] vhost_net: start/stop guest notifiers
	properly
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: William Dauchy <wdauchy@gmail.com>
Cc: zhangjie14@huawei.com, QEMU Developers <qemu-devel@nongnu.org>, mst@redhat.com

On 08/18/2014 09:20 PM, William Dauchy wrote:
> On Mon, Aug 18, 2014 at 11:51 AM, Jason Wang <jasowang@redhat.com> wrote:
>>  err:
>> @@ -254,16 +254,16 @@ void vhost_net_stop(VirtIODevice *dev, NetClientState *ncs,
>>      VirtioBusClass *k = VIRTIO_BUS_GET_CLASS(vbus);
>>      int i, r;
>>
>> +    for (i = 0; i < total_queues; i++) {
>> +        vhost_net_stop_one(tap_get_vhost_net(ncs[i].peer), dev);
>> +    }
>> +
>>      r = k->set_guest_notifiers(qbus->parent, total_queues * 2, false);
>>      if (r < 0) {
>>          fprintf(stderr, "vhost guest notifier cleanup failed: %d\n", r);
>>          fflush(stderr);
>>      }
>>      assert(r >= 0);
>> -
>> -    for (i = 0; i < total_queues; i++) {
>> -        vhost_net_stop_one(tap_get_vhost_net(ncs[i].peer), dev);
>> -    }
>>  }
> since
> ed8b4af Refactor virtio-net to use generic get_vhost_net
> get_vhost_net is used instead of tap_get_vhost_net
>
> Could you rebase your patch to facilitate tests or is it intentional?

Not intentional, my tree is out of date. I will rebase the patch.

Thanks for pointing this out.
>
> Thanks,