From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: zhangjie14@huawei.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] vhost_net: start/stop guest notifiers properly
Date: Tue, 19 Aug 2014 10:49:07 +0800 [thread overview]
Message-ID: <53F2BB23.9010506@redhat.com> (raw)
In-Reply-To: <20140818195328.GA30209@redhat.com>
On 08/19/2014 03:53 AM, Michael S. Tsirkin wrote:
> On Mon, Aug 18, 2014 at 05:51:31PM +0800, Jason Wang wrote:
>> > commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue
>> > support changed the order of stopping the device. Previously
>> > vhost_dev_stop would disable backend and only afterwards, unset guest
>> > notifiers. We now unset guest notifiers while vhost is still
>> > active. This can lose interrupts causing guest networking to fail.
>> >
>> > Additionally, remove the hdev->started assert in vhost.c since we may
>> > want to start the guest notifiers before vhost starts and stop the
>> > guest notifiers after vhost is stopped.
>> >
>> > In particular, this has been observed during migration.
>> >
>> > Reported-by: "Zhangjie (HZ)" <zhangjie14@huawei.com>
>> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>> > Signed-off-by: Jason Wang <jasowang@redhat.com>
> This doesn't seem to apply to master.
> Can you rebase please?
Yes, will send a new version.
prev parent reply other threads:[~2014-08-19 2:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-18 9:51 [Qemu-devel] [PATCH] vhost_net: start/stop guest notifiers properly Jason Wang
2014-08-18 12:11 ` Zhangjie (HZ)
2014-08-19 2:46 ` Jason Wang
2014-08-18 13:20 ` William Dauchy
2014-08-19 2:48 ` Jason Wang
2014-08-18 19:53 ` Michael S. Tsirkin
2014-08-19 2:49 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F2BB23.9010506@redhat.com \
--to=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhangjie14@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).