From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36341) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJaJ8-00019j-6A for qemu-devel@nongnu.org; Mon, 18 Aug 2014 23:42:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XJaJ3-00007L-CE for qemu-devel@nongnu.org; Mon, 18 Aug 2014 23:42:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34855) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJaJ3-00007D-44 for qemu-devel@nongnu.org; Mon, 18 Aug 2014 23:41:57 -0400 Message-ID: <53F2C77A.5020609@redhat.com> Date: Tue, 19 Aug 2014 11:41:46 +0800 From: Jason Wang MIME-Version: 1.0 References: <1408417373-59216-1-git-send-email-jasowang@redhat.com> In-Reply-To: <1408417373-59216-1-git-send-email-jasowang@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V2] vhost_net: start/stop guest notifiers properly List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mst@redhat.com, qemu-devel@nongnu.org, zhangjie14@huawei.com Cc: William Dauchy On 08/19/2014 11:02 AM, Jason Wang wrote: > commit a9f98bb5ebe6fb1869321dcc58e72041ae626ad8 vhost: multiqueue > support changed the order of stopping the device. Previously > vhost_dev_stop would disable backend and only afterwards, unset guest > notifiers. We now unset guest notifiers while vhost is still > active. This can lose interrupts causing guest networking to fail. > > Additionally, remove the hdev->started assert in vhost.c since we may > want to start the guest notifiers before vhost starts and stop the > guest notifiers after vhost is stopped. > > In particular, this has been observed during migration. > > Reported-by: "Zhangjie (HZ)" > Cc: William Dauchy > Signed-off-by: Michael S. Tsirkin > Signed-off-by: Jason Wang > > -- Looks like the patch breaks multiqueue test. I will post V3.