From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJk0O-0005yc-55 for qemu-devel@nongnu.org; Tue, 19 Aug 2014 10:03:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XJk0I-0004Kk-0A for qemu-devel@nongnu.org; Tue, 19 Aug 2014 10:03:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1696) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XJk0H-0004KZ-PX for qemu-devel@nongnu.org; Tue, 19 Aug 2014 10:03:13 -0400 Message-ID: <53F35914.1030304@redhat.com> Date: Tue, 19 Aug 2014 16:03:00 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1408441305-11044-1-git-send-email-arei.gonglei@huawei.com> <1408441305-11044-2-git-send-email-arei.gonglei@huawei.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] qdev: add missing error check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , gonglei Cc: "Huangweidong (C)" , "Michael S. Tsirkin" , peter.huangpeng@huawei.com, "qemu-devel@nongnu.org Developers" , Igor Mammedov , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Il 19/08/2014 15:50, Peter Crosthwaite ha scritto: > So I'm curious to know if and how this manifested for you as a bug? > Can you reproduce this as a bug somehow even as a memory leak? as the > only way I can see local_err getting populated is a fail of: > > object_property_add_child(container_get(qdev_get_machine(), > "/unattached"), > name, obj, &local_err); > > Which, if fails indicates something very wrong. Should we promote that > fail to &error_abort and just drop the local_err logic entirely? I'm > very interested on your replication conditions on this one. Yes, I don't think it can happen. The user can only refer to /machine/peripheral, not /machine/unattached. &error_abort is better. Paolo