From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56148)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1XJkPz-0002hh-33
	for qemu-devel@nongnu.org; Tue, 19 Aug 2014 10:29:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1XJkPr-0005up-Ia
	for qemu-devel@nongnu.org; Tue, 19 Aug 2014 10:29:47 -0400
Received: from cantor2.suse.de ([195.135.220.15]:34410 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1XJkPr-0005ul-C5
	for qemu-devel@nongnu.org; Tue, 19 Aug 2014 10:29:39 -0400
Message-ID: <53F35F51.6090702@suse.de>
Date: Tue, 19 Aug 2014 16:29:37 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1407594349-9291-1-git-send-email-eric.auger@linaro.org>
	<1407594349-9291-11-git-send-email-eric.auger@linaro.org>
	<53F27627.4030401@amd.com>
	<CAFEAcA80zcCvncbd0CrZXJMczrSUKp3MhjZOj+vqU586=e=9pw@mail.gmail.com>
	<53F27DA8.7010206@amd.com> <53F32E2F.3020609@suse.de>
	<53F35C1A.7090504@amd.com>
In-Reply-To: <53F35C1A.7090504@amd.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 10/10] hw/arm/dyn_sysbus_devtree: enable
 simple VFIO dynamic instantiation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Joel Schopp <joel.schopp@amd.com>, Peter Maydell <peter.maydell@linaro.org>
Cc: Kim Phillips <kim.phillips@freescale.com>, eric.auger@st.com, Eric Auger <eric.auger@linaro.org>, Patch Tracking <patches@linaro.org>, Will Deacon <will.deacon@arm.com>, Alvise Rigo <a.rigo@virtualopensystems.com>, QEMU Developers <qemu-devel@nongnu.org>, Bharat Bhushan <Bharat.Bhushan@freescale.com>, Alex Williamson <alex.williamson@redhat.com>, Stuart Yoder <stuart.yoder@freescale.com>, Antonios Motakis <a.motakis@virtualopensystems.com>, "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>, Christoffer Dall <christoffer.dall@linaro.org>



On 19.08.14 16:15, Joel Schopp wrote:
> 
>>> For the index [2*i],[2*i+1], etc is clearly a bug as when i = 1 it will
>>> overwrite two of the values.  Changing that to [4*i],[4*i+1],etc fixes it.
>>>
>>> I think you are right on the size.  I also wonder if the user doesn't
>>> pass in a dtb if qemu should try to recreate the device-tree entry from
>>> the platform device entry in the host kernel?  If so would that best be
>>> done by recreating the values from /proc/device-tree ?
>>>
>>> I also wish that qemu had a flag to output the generated dtb to a file
>>> much like lkvm (kvmtool) has.
>> It does. "qemu-system-foo -machine dumpdtb=mydtb.dtb" should dump the
>> generated dtb into a file called mydtb.dtb.
> 
> Would a patch that adds this output to --help be welcomed?

Not sure -help is the right place for these debugging options. But I
would definitely love to see all -machine options properly documented in
the man page!


Alex