From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56616)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1XJox8-0001c8-DG
	for qemu-devel@nongnu.org; Tue, 19 Aug 2014 15:20:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1XJox2-00011j-8W
	for qemu-devel@nongnu.org; Tue, 19 Aug 2014 15:20:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57224)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1XJox2-00011Q-1W
	for qemu-devel@nongnu.org; Tue, 19 Aug 2014 15:20:12 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7JJKBRm002050
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 19 Aug 2014 15:20:11 -0400
Message-ID: <53F3A366.1010307@redhat.com>
Date: Tue, 19 Aug 2014 15:20:06 -0400
From: John Snow <jsnow@redhat.com>
MIME-Version: 1.0
References: <1408050186-27800-1-git-send-email-jsnow@redhat.com>
	<20140818131229.GB1273@stefanha-thinkpad.redhat.com>
In-Reply-To: <20140818131229.GB1273@stefanha-thinkpad.redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3] ide: Add resize callback to ide/core
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com



On 08/18/2014 09:12 AM, Stefan Hajnoczi wrote:
> On Thu, Aug 14, 2014 at 05:03:06PM -0400, John Snow wrote:
>> @@ -162,10 +173,10 @@ static void ide_identify(IDEState *s)
>>       }
>>       put_le16(p + 88, 0x3f | (1 << 13)); /* udma5 set and supported *=
/
>>       put_le16(p + 93, 1 | (1 << 14) | 0x2000);
>> -    put_le16(p + 100, s->nb_sectors);
>> -    put_le16(p + 101, s->nb_sectors >> 16);
>> -    put_le16(p + 102, s->nb_sectors >> 32);
>> -    put_le16(p + 103, s->nb_sectors >> 48);
>> +    /* *(p + 100) :=3D nb_sectors       -- see ide_identify_size */
>> +    /* *(p + 101) :=3D nb_sectors >> 16 -- see ide_identify_size */
>> +    /* *(p + 102) :=3D nb_sectors >> 32 -- see ide_identify_size */
>> +    /* *(p + 103) :=3D nb_sectors >> 48 -- see ide_identify_size */
>
> These comments bitrot easily.  I'd prefer not to have them, but not a
> reason to respin:
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>

Ping? Respin w/o comments, or is this fine?

--=20
=97js