qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michal Privoznik <mprivozn@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>, Eric Blake <eblake@redhat.com>
Cc: libvir-list@redhat.com, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [libvirt] [PATCHv2 libvirt] qemu: Issue rtc-reset-reinjection command after guest-set-time
Date: Wed, 20 Aug 2014 10:11:18 +0200	[thread overview]
Message-ID: <53F45826.8040106@redhat.com> (raw)
In-Reply-To: <20140819172324.GA5717@amt.cnet>

On 19.08.2014 19:23, Marcelo Tosatti wrote:
> On Tue, Aug 19, 2014 at 11:00:26AM -0600, Eric Blake wrote:
>> On 08/19/2014 10:57 AM, Marcelo Tosatti wrote:
>>>
>>> rtc-reset-reinjection has been introduced because certain Windows
>>> versions will advance the guest system time (via rtc interrupt
>>> reinjection).
>>>
>>> So if libvirt adjusts the guest system time via guest-set-time,
>>> allowing rtc interrupt reinjection to compensate for lost time,
>>> as well, will cause an incorrect guest system time.
>>>
>>> So you should always use the
>>>
>>>      guest-set-time
>>>      rtc-reset-reinjection
>>>
>>> pair.
>>
>> But is that true both for the 'guest-set-time' no-arg case (which tells
>> the guest to read the current RTC and update in-memory time
>> accordingly), as well as the 'guest-set-time with time argument' case
>> (which tells the guest to forcefully set in-memory time, then write that
>> time back to the RTC)?
>
> Yes.
>

Okay then. I'm posting v3 here [1] which unconditionally calls the 
monitor command right after the guest agent command.

Michal

1: https://www.redhat.com/archives/libvir-list/2014-August/msg00867.html

      reply	other threads:[~2014-08-20  8:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <075846faf30f2244fbaaf2c9f47cbae58a9524db.1408004697.git.mprivozn@redhat.com>
     [not found] ` <53F21B82.4050006@redhat.com>
2014-08-18 16:29   ` [Qemu-devel] [libvirt] [PATCHv2 libvirt] qemu: Issue rtc-reset-reinjection command after guest-set-time Michal Privoznik
2014-08-19 16:57     ` Marcelo Tosatti
2014-08-19 17:00       ` Eric Blake
2014-08-19 17:23         ` Marcelo Tosatti
2014-08-20  8:11           ` Michal Privoznik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F45826.8040106@redhat.com \
    --to=mprivozn@redhat.com \
    --cc=eblake@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).