From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49704)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XK14j-0008G5-7N
	for qemu-devel@nongnu.org; Wed, 20 Aug 2014 04:17:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XK14e-0002mF-Fo
	for qemu-devel@nongnu.org; Wed, 20 Aug 2014 04:16:57 -0400
Received: from mail-wi0-x236.google.com ([2a00:1450:400c:c05::236]:47484)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XK14e-0002m3-8e
	for qemu-devel@nongnu.org; Wed, 20 Aug 2014 04:16:52 -0400
Received: by mail-wi0-f182.google.com with SMTP id d1so6500104wiv.3
	for <qemu-devel@nongnu.org>; Wed, 20 Aug 2014 01:16:51 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <53F4596F.6020603@redhat.com>
Date: Wed, 20 Aug 2014 10:16:47 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1408444983-21464-1-git-send-email-pbonzini@redhat.com>	<1408444983-21464-20-git-send-email-pbonzini@redhat.com>	<CAFEAcA8oPAa6MBNZaV0JqsPzw-MKgJkfFwVOk+HsZJ9Q_SGRkA@mail.gmail.com>	<CAEgOgz6onrRr6oAJAfURBhYGXsS=nqBdJ2pi_S=GtkgY-2u7kg@mail.gmail.com>
	<CAFEAcA-xzJCQq-Z4pKcE7ewU3s6jZVn_qkx_b5Dtug0MJXxbcA@mail.gmail.com>
In-Reply-To: <CAFEAcA-xzJCQq-Z4pKcE7ewU3s6jZVn_qkx_b5Dtug0MJXxbcA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 19/20] memory: Use canonical path component
	as the name
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

Il 20/08/2014 09:50, Peter Maydell ha scritto:
> On 20 August 2014 06:04, Peter Crosthwaite <peter.crosthwaite@xilinx.com> wrote:
>> On Wed, Aug 20, 2014 at 5:01 AM, Peter Maydell <peter.maydell@linaro.org> wrote:
>>> I think we need to revert this (commit b0225c2c0d8) until
>>> both the Xen callsites are fixed and the leak issue is
>>> dealt with.
>>>
>>
>> Have half a plan on the leak issue. With
>> object_get_canonical_path_component() being used increasing as a "get
>> me the already set, name of this object", I think it's better to just
>> change to API to return const and remove the free burden from all call
>> sites completely. If call sites really want a fresh copy they can take
>> one themselves. Patch on list imminently.
> 
> I'm going to go ahead and revert this patch for the moment so
> we can take our time reviewing that patch set.

Yes, thanks.

Paolo