From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Knut Omang <knut.omang@oracle.com>
Cc: Juan Quintela <quintela@redhat.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
Marcel Apfelbaum <marcel.a@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
qemu-devel@nongnu.org, Gonglei <arei.gonglei@huawei.com>,
Igor Mammedov <imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function
Date: Wed, 20 Aug 2014 15:20:02 +0200 [thread overview]
Message-ID: <53F4A082.7090103@redhat.com> (raw)
In-Reply-To: <20140820113627.GG17371@redhat.com>
Il 20/08/2014 13:36, Michael S. Tsirkin ha scritto:
>
> For pci bridges, unless you set bus_name, bus name will
> match device itself. See this code:
>
> * If we don't specify the name, the bus will be addressed as
> * <id>.0, where id is the device id.
> * Since PCI Bridge devices have a single bus each, we don't need
> * the index:
> * let users address the bus using the device name.
> */
> if (!br->bus_name && dev->qdev.id && *dev->qdev.id) {
> br->bus_name = dev->qdev.id;
> }
Is libvirt using this rule? If not, I'd rather slash it since the
<id>.0 name is shared with all other buses and not PCI-bridge-specific.
Paolo
next prev parent reply other threads:[~2014-08-20 13:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 6:53 [Qemu-devel] [PATCH 2/3] ioh3420: Provide a unique bus name and an interrupt mapping function Knut Omang
2014-08-20 8:52 ` Paolo Bonzini
2014-08-20 9:30 ` Knut Omang
2014-08-20 11:36 ` Michael S. Tsirkin
2014-08-20 13:08 ` Knut Omang
2014-08-20 13:20 ` Paolo Bonzini [this message]
2014-08-20 14:57 ` Markus Armbruster
2014-08-20 18:32 ` Eric Blake
2014-08-21 11:49 ` Paolo Bonzini
2014-08-20 12:06 ` Markus Armbruster
2014-08-20 12:33 ` Michael S. Tsirkin
2014-08-20 13:03 ` Markus Armbruster
2014-08-20 13:18 ` Paolo Bonzini
2014-08-20 14:28 ` Markus Armbruster
2014-08-20 11:49 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F4A082.7090103@redhat.com \
--to=pbonzini@redhat.com \
--cc=aik@ozlabs.ru \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=imammedo@redhat.com \
--cc=knut.omang@oracle.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).