From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50138) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKBDm-000329-UH for qemu-devel@nongnu.org; Wed, 20 Aug 2014 15:07:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKBDg-0007Fx-EP for qemu-devel@nongnu.org; Wed, 20 Aug 2014 15:06:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49993) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKBDf-0007Es-VJ for qemu-devel@nongnu.org; Wed, 20 Aug 2014 15:06:52 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7KJ6pik000882 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 20 Aug 2014 15:06:51 -0400 Message-ID: <53F4F1C8.7070404@redhat.com> Date: Wed, 20 Aug 2014 21:06:48 +0200 From: Max Reitz MIME-Version: 1.0 References: <1406064567-27907-1-git-send-email-mreitz@redhat.com> <53EE25CE.4030102@redhat.com> <20140820114533.GG6122@noname.redhat.com> In-Reply-To: <20140820114533.GG6122@noname.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v10 00/14] qemu-img: Implement commit like QMP List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, Stefan Hajnoczi On 20.08.2014 13:45, Kevin Wolf wrote: > Am 15.08.2014 um 17:22 hat Max Reitz geschrieben: >> On 22.07.2014 23:29, Max Reitz wrote: >>> qemu-img should use QMP commands whenever possible in order to ensure >>> feature completeness of both online and offline image operations. For >>> the "commit" command, this is relatively easy, so implement it first >>> (in the hope that indeed others will follow). >>> >>> As qemu-img does not have access to QMP (due to QMP being intertwined >>> with basically everything in qemu), we cannot directly use QMP, but at >>> least use the functions the corresponding QMP commands are using (which >>> would be "block-commit", in this case). >> Ping > This doesn't apply cleanly any more. Okay, I sent a rebase (with only contextual changes). Max