From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKBFe-0004X9-U2 for qemu-devel@nongnu.org; Wed, 20 Aug 2014 15:09:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKBFU-00080W-HR for qemu-devel@nongnu.org; Wed, 20 Aug 2014 15:08:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50178) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKBFU-00080M-A2 for qemu-devel@nongnu.org; Wed, 20 Aug 2014 15:08:44 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7KJ8h9c022432 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 20 Aug 2014 15:08:43 -0400 Message-ID: <53F4F238.2040104@redhat.com> Date: Wed, 20 Aug 2014 21:08:40 +0200 From: Max Reitz MIME-Version: 1.0 References: <1405707901-8253-1-git-send-email-mreitz@redhat.com> <1405707901-8253-3-git-send-email-mreitz@redhat.com> <20140820151424.GI6122@noname.redhat.com> In-Reply-To: <20140820151424.GI6122@noname.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/6] blkdebug: Implement bdrv_refresh_filename() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, Stefan Hajnoczi On 20.08.2014 17:14, Kevin Wolf wrote: > Am 18.07.2014 um 20:24 hat Max Reitz geschrieben: >> Because blkdebug cannot simply create a configuration file, simply >> refuse to reconstruct a plain filename and only generate an options >> QDict from the rules instead. >> >> Signed-off-by: Max Reitz >> --- >> Instead of this rather complicated implementation, we could decide to >> just drop it and let this be handled by the default implementation. The >> default implementation however cannot generate full_open_options in case >> a configuration file was given; in that case, it would just return the >> filename containing the name of the configuration file. On the other >> hand, blkdebug is just a debug driver anyway, so it probably wouldn't >> hurt too much. > I think you really want to have the config file name used here for > options that were loaded from a config file, and the explicit JSON > notation only for options explicitly specified on the command line or in > blockdev-add. > > We still only have 1024 characters for bs->filename... ;-) But who uses blkdebug anyway. *g* I'll take a look into this, along with whether we can minimize use of BDS.filename enough to justify completely removing it. Max