From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/4] qapi: Allow enums in anonymous unions
Date: Wed, 20 Aug 2014 13:15:34 -0600 [thread overview]
Message-ID: <53F4F3D6.6090102@redhat.com> (raw)
In-Reply-To: <1408557576-14574-3-git-send-email-mreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 606 bytes --]
On 08/20/2014 11:59 AM, Max Reitz wrote:
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> scripts/qapi-types.py | 2 ++
> scripts/qapi-visit.py | 3 ++-
> 2 files changed, 4 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
(On a tangentially related note, I'd still like to get to the point
where we can have a 'discriminator' in a union even without a 'base' -
the fact that flat unions are typesafe but old-style unions are not is a
bit annoying)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-08-20 19:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 17:59 [Qemu-devel] [PATCH 0/4] qapi/block-core: Add "new" qcow2 options Max Reitz
2014-08-20 17:59 ` [Qemu-devel] [PATCH 1/4] qcow2: Fix leak of QemuOpts in qcow2_open() Max Reitz
2014-08-20 19:10 ` Eric Blake
2014-08-21 17:54 ` Benoît Canet
2014-08-20 17:59 ` [Qemu-devel] [PATCH 2/4] qapi: Allow enums in anonymous unions Max Reitz
2014-08-20 19:15 ` Eric Blake [this message]
2014-08-20 17:59 ` [Qemu-devel] [PATCH 3/4] qcow2: Add overlap-check.template option Max Reitz
2014-08-20 19:22 ` Eric Blake
2014-08-20 19:27 ` Eric Blake
2014-08-20 19:30 ` Max Reitz
2014-08-20 17:59 ` [Qemu-devel] [PATCH 4/4] qapi/block-core: Add "new" qcow2 options Max Reitz
2014-08-20 19:36 ` Eric Blake
2014-08-20 19:38 ` Max Reitz
2014-08-20 19:45 ` Eric Blake
2014-09-17 13:12 ` [Qemu-devel] [PATCH 0/4] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F4F3D6.6090102@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).