From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58494) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKOG9-0008DT-WD for qemu-devel@nongnu.org; Thu, 21 Aug 2014 05:02:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKOG0-0001Gu-VX for qemu-devel@nongnu.org; Thu, 21 Aug 2014 05:02:17 -0400 Received: from mail-we0-x22a.google.com ([2a00:1450:400c:c03::22a]:50058) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKOG0-0001Go-Ou for qemu-devel@nongnu.org; Thu, 21 Aug 2014 05:02:08 -0400 Received: by mail-we0-f170.google.com with SMTP id w62so8978527wes.1 for ; Thu, 21 Aug 2014 02:02:07 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <53F5B58C.3090109@redhat.com> Date: Thu, 21 Aug 2014 11:02:04 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1408528887-22200-1-git-send-email-famz@redhat.com> <1408528887-22200-7-git-send-email-famz@redhat.com> <53F4A363.5020904@redhat.com> <20140821035426.GK2943@T430.nay.redhat.com> In-Reply-To: <20140821035426.GK2943@T430.nay.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 6/6] iscsi: Move iqn generation code to util List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, mjt@tls.msk.ru, qemu-devel@nongnu.org, stefanha@redhat.com Il 21/08/2014 05:54, Fam Zheng ha scritto: >> > In any case, if we need it I think there's no need to keep the argument >> > to iqn_generate. > How about multiple initiators? Should they use the same iqn? block/iscsi.c uses -iscsi for the options so that you don't have to place them in cleartext in the command line (instead you can use a -readconfig file and delete them). user and password can be included in the URL as well, though, and we could add an initiator-name option to the iscsi driver to be used with qemu-img/qemu-io. The default would remain to always use the same iqn. Paolo