From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, mjt@tls.msk.ru, qemu-devel@nongnu.org,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 5/6] build-sys: Change libqemuutil.a to qemuutil.o and link whole object
Date: Thu, 21 Aug 2014 11:04:11 +0200 [thread overview]
Message-ID: <53F5B60B.9000901@redhat.com> (raw)
In-Reply-To: <20140821030249.GJ2943@T430.nay.redhat.com>
Il 21/08/2014 05:02, Fam Zheng ha scritto:
> On Wed, 08/20 15:29, Paolo Bonzini wrote:
>> Il 20/08/2014 12:01, Fam Zheng ha scritto:
>>> +
>>> +qemuutil.o: CC_REL_FLAGS := -Wl,-r
>>
>> Why the target-specific rule?
>>
>>> +qemuutil.o: $(util-obj-y)
>>> + $(call quiet-command,$(CC) -nostdlib $(CC_REL_FLAGS) -o $@ $^," LD -r $(TARGET_DIR)$@")
>>>
>>
>>
>> I think either you have
>>
>> LD_REL := $(CC) -nostdlib -Wl,-r
>>
>> (as opposed to "LD_REL := $(LD) -r" for example) or you do not need to
>> put -Wl,-r in a separate variable.
>
> Because comma doesn't work in Makefile macro invocation, we need to wrap the
> flag in a variable. (Is there a way to escape it?)
Well, there's
comma=,
and $(comma). Or
Wl=-Wl,
of course. But neither is particularly nice.
> Your LD_REL looks cleaner though.
Okay, let's go with it then.
Paolo
next prev parent reply other threads:[~2014-08-21 9:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 10:01 [Qemu-devel] [PATCH 0/6] build-sys: Fix iscsi module loading failure Fam Zheng
2014-08-20 10:01 ` [Qemu-devel] [PATCH 1/6] build-sys: Move fifio8 to hw/ Fam Zheng
2014-08-20 13:33 ` Paolo Bonzini
2014-08-20 14:23 ` Peter Crosthwaite
2014-08-20 14:52 ` Fam Zheng
2014-08-20 10:01 ` [Qemu-devel] [PATCH 2/6] stubs: Add iohandler.c Fam Zheng
2014-08-20 13:25 ` Paolo Bonzini
2014-08-20 10:01 ` [Qemu-devel] [PATCH 3/6] stubs: Add openpty.c Fam Zheng
2014-08-20 13:26 ` Paolo Bonzini
2014-08-20 10:01 ` [Qemu-devel] [PATCH 4/6] stubs: Add timer.c Fam Zheng
2014-08-20 13:27 ` Paolo Bonzini
2014-08-20 10:01 ` [Qemu-devel] [PATCH 5/6] build-sys: Change libqemuutil.a to qemuutil.o and link whole object Fam Zheng
2014-08-20 13:29 ` Paolo Bonzini
2014-08-21 3:02 ` Fam Zheng
2014-08-21 9:04 ` Paolo Bonzini [this message]
2014-08-20 10:01 ` [Qemu-devel] [PATCH 6/6] iscsi: Move iqn generation code to util Fam Zheng
2014-08-20 13:32 ` Paolo Bonzini
2014-08-20 15:03 ` Fam Zheng
2014-08-21 3:54 ` Fam Zheng
2014-08-21 9:02 ` Paolo Bonzini
2014-08-21 9:12 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F5B60B.9000901@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).