qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Marc Marí" <marc.mari.barcelo@gmail.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org, "Stefan Hajnoczi" <stefanha@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [RFC] qapi: New command query-mtree
Date: Thu, 21 Aug 2014 11:56:24 +0200	[thread overview]
Message-ID: <53F5C248.1090907@redhat.com> (raw)
In-Reply-To: <20140821111810.785eaad2@crunchbang>

Il 21/08/2014 11:18, Marc Marí ha scritto:
> El Thu, 21 Aug 2014 11:06:51 +0200
> Paolo Bonzini <pbonzini@redhat.com> escribió:
>> Il 20/08/2014 19:46, Marc Marí ha scritto:
>>> Add command query-mtree to get the memory tree of the guest.
>>>
>>> As we were looking for a flexible solution on accessing the guest
>>> memory from qtests, Stefan came with the idea to implement this new
>>> qmp command.
>>>
>>> This way, the result can be parsed, and the RAM direction
>>> extracted, so only a generic qtest malloc is necessary and not one
>>> per machine, as it is implemented at the moment (malloc-pc uses
>>> fw_cfg).
>>>
>>> The actual output is this: http://pastebin.com/nHAH9Jie
>>> Which corresponds to this info mtree: http://pastebin.com/B5vw8DDf
>>
>> I don't like this idea very much.  libqos should be using the real
>> memory map information from the machine.  In the case of x86, that
>> means fw_cfg; in the case of ARM, that would mean using the device
>> tree. Getting the information from an out-of-band channel (such as
>> QMP) is basically cheating. :)
> 
> As we were looking at how to access the device tree, we found that the
> device tree is saved in memory with the bootloader or the kernel. So
> tests should be using a kernel every time a ARM machine is booted
> (and /dev/null, at least in virt machine, does not work). Do you have
> any better idea on how to do it?

It works for me:

$ qemu-system-arm -M virt -S -kernel /dev/null -initrd /dev/null \
     -qtest stdio -qtest-log /dev/null
readl 0x40000014
OK 0x0000000044000000
read 0x44000084 20
OK 0x6c696e75782c64756d6d792d7669727400000000

where this string is "linux,dummy-virt".  QMP could be used to provide
the program counter (via "query-cpus"), but it currently doesn't on ARM.
 Perhaps you could make a simple patch to cpus.c for that?

Paolo

      parent reply	other threads:[~2014-08-21  9:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-20 17:46 [Qemu-devel] [RFC] qapi: New command query-mtree Marc Marí
2014-08-20 19:09 ` Eric Blake
2014-08-20 20:08   ` Marc Marí
2014-08-20 20:12   ` Eric Blake
2014-08-21  9:06 ` Paolo Bonzini
2014-08-21  9:18   ` Marc Marí
2014-08-21  9:47     ` Paolo Bonzini
2014-08-21  9:56     ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F5C248.1090907@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=afaerber@suse.de \
    --cc=marc.mari.barcelo@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).