From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53308)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1XKQ2C-0004op-Ir
	for qemu-devel@nongnu.org; Thu, 21 Aug 2014 06:56:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1XKQ25-0006Du-2P
	for qemu-devel@nongnu.org; Thu, 21 Aug 2014 06:56:00 -0400
Received: from cantor2.suse.de ([195.135.220.15]:45430 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1XKQ24-0006DY-Ry
	for qemu-devel@nongnu.org; Thu, 21 Aug 2014 06:55:52 -0400
Message-ID: <53F5D036.9010005@suse.de>
Date: Thu, 21 Aug 2014 12:55:50 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <7dadfa99c7a31615e6df922fb6e2084837e08033.1408584788.git.alistair23@gmail.com>	<CAKmqyKMV1nN5bGxcV6wH5+zrL_HbO9+rp+mB4ni3717FcLKvyQ@mail.gmail.com>
	<CAEgOgz7vVSp2R_0za4pMzSKWx91ZLXUnXV2qo=G2Q+xgmKBLAg@mail.gmail.com>
In-Reply-To: <CAEgOgz7vVSp2R_0za4pMzSKWx91ZLXUnXV2qo=G2Q+xgmKBLAg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v1 1/1] target_arm: Make the reset rom_ptr
 a property
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, Alistair Francis <alistair23@gmail.com>
Cc: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Konstanty Bialkowski <konstanty@ieee.org>

Am 21.08.2014 05:37, schrieb Peter Crosthwaite:
> On Thu, Aug 21, 2014 at 11:40 AM, Alistair Francis <alistair23@gmail.co=
m> wrote:
>> On Thu, Aug 21, 2014 at 11:36 AM, Alistair Francis <alistair23@gmail.c=
om> wrote:
>>> diff --git a/target-arm/cpu-qom.h b/target-arm/cpu-qom.h
>>> index 07f3c9e..7e415f5 100644
>>> --- a/target-arm/cpu-qom.h
>>> +++ b/target-arm/cpu-qom.h
>>> @@ -138,6 +138,7 @@ typedef struct ARMCPU {
>>>      uint32_t id_isar3;
>>>      uint32_t id_isar4;
>>>      uint32_t id_isar5;
>>> +    uint32_t rom_address;
>=20
> Any reason for this to go in amongst the ID register fields? It seems
> in a class of its own, and the closest thing to it would be rvbar
> which is down the bottom. My gut says it should be last field in the
> struct.

Whether it is zero'ed on reset here would be another concern.

Regards,
Andreas

>>>      uint64_t id_aa64pfr0;
>>>      uint64_t id_aa64pfr1;
>>>      uint64_t id_aa64dfr0;
[snip]

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg