From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, Kevin Wolf <kwolf@redhat.com>
Cc: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/1] vmdk: Use bdrv_nb_sectors() where sectors, not bytes are wanted
Date: Thu, 21 Aug 2014 06:33:30 -0600 [thread overview]
Message-ID: <53F5E71A.2060707@redhat.com> (raw)
In-Reply-To: <87y4ui58xi.fsf@blackfin.pond.sub.org>
[-- Attachment #1: Type: text/plain, Size: 761 bytes --]
On 08/21/2014 06:22 AM, Markus Armbruster wrote:
> Kevin Wolf <kwolf@redhat.com> writes:
>
>> The worst part is that it got a Reviewed-by which might just have fooled
>> me if Fam hadn't reviewed it as well. :-/
>
> This kind of idiotic error is hard to spot in review for the same reason
> it's easy to make when tired.
Indeed; I had merely reviewed that the patch looked sane, and not
actually tested against a testsuite, so I'm glad Fam caught it. There's
a reason I've been sticking with Reviewed-by and not Tested-by, although
I agree that enhancing the testsuite to make sure dumb things like this
get caught is worthwhile.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
prev parent reply other threads:[~2014-08-21 12:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 17:07 [Qemu-devel] [PATCH 1/1] vmdk: Use bdrv_nb_sectors() where sectors, not bytes are wanted Markus Armbruster
2014-08-20 18:55 ` Eric Blake
2014-08-21 1:15 ` Fam Zheng
2014-08-21 6:43 ` Markus Armbruster
2014-08-21 7:09 ` Fam Zheng
2014-08-21 8:35 ` Kevin Wolf
2014-08-21 12:22 ` Markus Armbruster
2014-08-21 12:33 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F5E71A.2060707@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).