From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44711) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKRYg-00022R-7n for qemu-devel@nongnu.org; Thu, 21 Aug 2014 08:33:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKRYa-0002BO-MY for qemu-devel@nongnu.org; Thu, 21 Aug 2014 08:33:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30982) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKRYa-00029w-DQ for qemu-devel@nongnu.org; Thu, 21 Aug 2014 08:33:32 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7LCXVOV002285 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 21 Aug 2014 08:33:31 -0400 Message-ID: <53F5E71A.2060707@redhat.com> Date: Thu, 21 Aug 2014 06:33:30 -0600 From: Eric Blake MIME-Version: 1.0 References: <1408554429-22341-1-git-send-email-armbru@redhat.com> <20140821011523.GC2943@T430.nay.redhat.com> <8738cql4vo.fsf@blackfin.pond.sub.org> <20140821083531.GE4452@noname.redhat.com> <87y4ui58xi.fsf@blackfin.pond.sub.org> In-Reply-To: <87y4ui58xi.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="r7rvfbjakolEcr1MMJqEDDgVbskQuTHRW" Subject: Re: [Qemu-devel] [PATCH 1/1] vmdk: Use bdrv_nb_sectors() where sectors, not bytes are wanted List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Kevin Wolf Cc: Fam Zheng , qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --r7rvfbjakolEcr1MMJqEDDgVbskQuTHRW Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/21/2014 06:22 AM, Markus Armbruster wrote: > Kevin Wolf writes: >=20 >> The worst part is that it got a Reviewed-by which might just have fool= ed >> me if Fam hadn't reviewed it as well. :-/ >=20 > This kind of idiotic error is hard to spot in review for the same reaso= n > it's easy to make when tired. Indeed; I had merely reviewed that the patch looked sane, and not actually tested against a testsuite, so I'm glad Fam caught it. There's a reason I've been sticking with Reviewed-by and not Tested-by, although I agree that enhancing the testsuite to make sure dumb things like this get caught is worthwhile. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --r7rvfbjakolEcr1MMJqEDDgVbskQuTHRW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT9ecaAAoJEKeha0olJ0Nqo54IAKacWnDfF9yYDNbwDDWiQQww kZh7b/CPyyprvekdBeQhAQ13+gs4JHKJFnGeJjNSOoK5hKlifzv/TFIN6KmYAHd9 FQ70MsZ8Ke0FBOSHZMqyLBRbVwsslTf0bbUbjuAmEkwb69GGxhAVq/LLK2MY66ay eVRPsS7VhPrSO5kcZk7Qz8nM3hgz2Secp2f/r5iPRjxlJh8OFXROnWbMlFIq7tWJ FC0fdRev39C8DUKeSGFdTzNtduiXZ4DYlzc//XTfLKOSKfzZsZWenRNGjmGlR0GI EJCuhXS2mTpapIlkZfdO9pl54nF45YMu3iPayAyVSoWqCsM8DPYualRjmWNQhMk= =0+n2 -----END PGP SIGNATURE----- --r7rvfbjakolEcr1MMJqEDDgVbskQuTHRW--