[Qemu-devel] [PULL 00/01] seccomp: add semctl() to the syscall whitelist

[Qemu-devel] [PULL 00/01] seccomp: add semctl() to the syscall whitelist

[Eduardo Otubo]

The following changes since commit 2656eb7c599e306b95bad82b1372fc49ba3088f6:

  Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20140819' into staging (2014-08-20 09:55:42 +0100)

are available in the git repository at:


  git@github.com:otubo/qemu.git seccomp

for you to fetch changes up to b22876cc2f863c58cfebd4a5301fc47e8ec89228:

  seccomp: add semctl() to the syscall whitelist (2014-08-21 10:29:16 +0200)

----------------------------------------------------------------
Paul Moore (1):
      seccomp: add semctl() to the syscall whitelist

 qemu-seccomp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

[Qemu-devel] [PULL 01/01] seccomp: add semctl() to the syscall whitelist

[Eduardo Otubo]

From: Paul Moore <pmoore@redhat.com>

QEMU needs to call semctl() for correct operation.  This particular
problem was identified on shutdown with the following commandline:

 # qemu -sandbox on -monitor stdio \
   -device intel-hda -device hda-duplex -vnc :0

Signed-off-by: Paul Moore <pmoore@redhat.com>
Signed-off-by: Eduardo Otubo <eduardo.otubo@profitbricks.com>
---
 qemu-seccomp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/qemu-seccomp.c b/qemu-seccomp.c
index ea8094d..0503764 100644
--- a/qemu-seccomp.c
+++ b/qemu-seccomp.c
@@ -230,7 +230,8 @@ static const struct QemuSeccompSyscall seccomp_whitelist[] = {
     { SCMP_SYS(timerfd_create), 240 },
     { SCMP_SYS(shmctl), 240 },
     { SCMP_SYS(mlock), 240 },
-    { SCMP_SYS(munlock), 240 }
+    { SCMP_SYS(munlock), 240 },
+    { SCMP_SYS(semctl), 240 }
 };
 
 int seccomp_start(void)
-- 
1.9.1

Re: [Qemu-devel] [PULL 00/01] seccomp: add semctl() to the syscall whitelist

[Peter Maydell]

On 21 August 2014 09:39, Eduardo Otubo <eduardo.otubo@profitbricks.com> wrote:
> The following changes since commit 2656eb7c599e306b95bad82b1372fc49ba3088f6:
>
>   Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20140819' into staging (2014-08-20 09:55:42 +0100)
>
> are available in the git repository at:
>
>
>   git@github.com:otubo/qemu.git seccomp
>
> for you to fetch changes up to b22876cc2f863c58cfebd4a5301fc47e8ec89228:
>
>   seccomp: add semctl() to the syscall whitelist (2014-08-21 10:29:16 +0200)

Applied, thanks. PS: git@github... isn't a valid git remote
name for other people; I'd appreciate it if you could fix the
scripts/workflow you use to create these pullreq emails to
get it right. You want "git://github.com/otubo/qemu.git".

-- PMM

Re: [Qemu-devel] [PULL 00/01] seccomp: add semctl() to the syscall whitelist

[Paolo Bonzini]

Il 21/08/2014 14:42, Peter Maydell ha scritto:
>> >   seccomp: add semctl() to the syscall whitelist (2014-08-21 10:29:16 +0200)
> Applied, thanks. PS: git@github... isn't a valid git remote
> name for other people; I'd appreciate it if you could fix the
> scripts/workflow you use to create these pullreq emails to
> get it right. You want "git://github.com/otubo/qemu.git".

... which means setting the "pushurl" in .git/config to the git@github:
remote name, and the "url" to the git://github.com/ one.

Paolo