From: Richard Henderson <rth@twiddle.net>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>,
qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH v5 10/15] target-tricore: Add instructions of SB opcode format
Date: Thu, 21 Aug 2014 13:41:50 -0700 [thread overview]
Message-ID: <53F6598E.4060404@twiddle.net> (raw)
In-Reply-To: <1407931644-25602-11-git-send-email-kbastian@mail.uni-paderborn.de>
On 08/13/2014 05:07 AM, Bastian Koppelmann wrote:
> @@ -679,9 +768,11 @@ gen_intermediate_code_internal(TRICORECPU *cpu, struct TranslationBlock *tb,
> num_insns++;
>
> if (tcg_ctx.gen_opc_ptr >= gen_opc_end) {
> + gen_goto_tb(&ctx, 0, ctx.next_pc);
> break;
> }
> if (singlestep) {
> + gen_goto_tb(&ctx, 0, ctx.next_pc);
> break;
> }
Do not use goto_tb under singlestep. That can make it very hard to debug
translator bugs. I've been considering checking for that at the tcg level,
except that almost all translators have this bug.
r~
next prev parent reply other threads:[~2014-08-21 20:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-13 12:07 [Qemu-devel] [PATCH v5 00/15] TriCore architecture guest implementation Bastian Koppelmann
2014-08-13 12:07 ` [Qemu-devel] [PATCH v5 01/15] target-tricore: Add target stubs and qom-cpu Bastian Koppelmann
2014-08-20 14:16 ` Richard Henderson
2014-08-13 12:07 ` [Qemu-devel] [PATCH v5 02/15] target-tricore: Add board for systemmode Bastian Koppelmann
2014-08-13 12:07 ` [Qemu-devel] [PATCH v5 03/15] target-tricore: Add softmmu support Bastian Koppelmann
2014-08-20 14:17 ` Richard Henderson
2014-08-13 12:07 ` [Qemu-devel] [PATCH v5 04/15] target-tricore: Add initialization for translation and activate target Bastian Koppelmann
2014-08-20 15:52 ` Richard Henderson
2014-08-13 12:07 ` [Qemu-devel] [PATCH v5 05/15] target-tricore: Add masks and opcodes for decoding Bastian Koppelmann
2014-08-20 15:52 ` Richard Henderson
2014-08-13 12:07 ` [Qemu-devel] [PATCH v5 06/15] target-tricore: Add instructions of SRC opcode format Bastian Koppelmann
2014-08-21 20:32 ` Richard Henderson
2014-08-13 12:07 ` [Qemu-devel] [PATCH v5 07/15] target-tricore: Add instructions of SRR " Bastian Koppelmann
2014-08-21 20:35 ` Richard Henderson
2014-08-13 12:07 ` [Qemu-devel] [PATCH v5 08/15] target-tricore: Add instructions of SSR " Bastian Koppelmann
2014-08-13 12:07 ` [Qemu-devel] [PATCH v5 09/15] target-tricore: Add instructions of SRRS and SLRO " Bastian Koppelmann
2014-08-21 20:37 ` Richard Henderson
2014-08-13 12:07 ` [Qemu-devel] [PATCH v5 10/15] target-tricore: Add instructions of SB " Bastian Koppelmann
2014-08-21 20:41 ` Richard Henderson [this message]
2014-08-13 12:07 ` [Qemu-devel] [PATCH v5 11/15] target-tricore: Add instructions of SBC and SBRN " Bastian Koppelmann
2014-08-13 12:07 ` [Qemu-devel] [PATCH v5 12/15] target-tricore: Add instructions of SBR " Bastian Koppelmann
2014-08-13 12:07 ` [Qemu-devel] [PATCH v5 13/15] target-tricore: Add instructions of SC " Bastian Koppelmann
2014-08-13 12:07 ` [Qemu-devel] [PATCH v5 14/15] target-tricore: Add instructions of SLR, SSRO and SRO " Bastian Koppelmann
2014-08-13 12:07 ` [Qemu-devel] [PATCH v5 15/15] target-tricore: Add instructions of SR " Bastian Koppelmann
2014-08-21 20:48 ` Richard Henderson
2014-08-22 16:35 ` Bastian Koppelmann
2014-08-20 13:17 ` [Qemu-devel] [PATCH v5 00/15] TriCore architecture guest implementation Andreas Färber
2014-08-20 14:44 ` Bastian Koppelmann
2014-08-20 14:06 ` Bastian Koppelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F6598E.4060404@twiddle.net \
--to=rth@twiddle.net \
--cc=kbastian@mail.uni-paderborn.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).