From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56821)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XKZBP-0004ub-Hz
	for qemu-devel@nongnu.org; Thu, 21 Aug 2014 16:42:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XKZBC-000706-S0
	for qemu-devel@nongnu.org; Thu, 21 Aug 2014 16:42:07 -0400
Received: from mail-qa0-x234.google.com ([2607:f8b0:400d:c00::234]:63515)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XKZBC-0006yu-ND
	for qemu-devel@nongnu.org; Thu, 21 Aug 2014 16:41:54 -0400
Received: by mail-qa0-f52.google.com with SMTP id j15so8639286qaq.25
	for <qemu-devel@nongnu.org>; Thu, 21 Aug 2014 13:41:54 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <53F6598E.4060404@twiddle.net>
Date: Thu, 21 Aug 2014 13:41:50 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1407931644-25602-1-git-send-email-kbastian@mail.uni-paderborn.de>
	<1407931644-25602-11-git-send-email-kbastian@mail.uni-paderborn.de>
In-Reply-To: <1407931644-25602-11-git-send-email-kbastian@mail.uni-paderborn.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v5 10/15] target-tricore: Add instructions
 of SB opcode format
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org

On 08/13/2014 05:07 AM, Bastian Koppelmann wrote:
> @@ -679,9 +768,11 @@ gen_intermediate_code_internal(TRICORECPU *cpu, struct TranslationBlock *tb,
>          num_insns++;
>  
>          if (tcg_ctx.gen_opc_ptr >= gen_opc_end) {
> +            gen_goto_tb(&ctx, 0, ctx.next_pc);
>              break;
>          }
>          if (singlestep) {
> +            gen_goto_tb(&ctx, 0, ctx.next_pc);
>              break;
>          }

Do not use goto_tb under singlestep.  That can make it very hard to debug
translator bugs.  I've been considering checking for that at the tcg level,
except that almost all translators have this bug.


r~