* [Qemu-devel] [PATCH v2] scsi-generic: remove superfluous DPRINTF avoid to break compiling
@ 2014-08-22 2:01 arei.gonglei
2014-08-22 8:54 ` Paolo Bonzini
0 siblings, 1 reply; 2+ messages in thread
From: arei.gonglei @ 2014-08-22 2:01 UTC (permalink / raw)
To: qemu-devel; +Cc: pbonzini, Gonglei, weidong.huang
From: Gonglei <arei.gonglei@huawei.com>
variables lun and tag had been eliminated, break compiling
when enable debug switch. Meanwhile traces provide the same
information with this DPRINTF, so remove it.
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
---
v2:
- as Paolo's suggestion, remove the superfluous DPRINTF.
- change patch topic and commit message.
---
hw/scsi/scsi-generic.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c
index 0b2ff90..0b352fc 100644
--- a/hw/scsi/scsi-generic.c
+++ b/hw/scsi/scsi-generic.c
@@ -303,9 +303,6 @@ static int32_t scsi_send_command(SCSIRequest *req, uint8_t *cmd)
SCSIDevice *s = r->req.dev;
int ret;
- DPRINTF("Command: lun=%d tag=0x%x len %zd data=0x%02x", lun, tag,
- r->req.cmd.xfer, cmd[0]);
-
#ifdef DEBUG_SCSI
{
int i;
--
1.7.12.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH v2] scsi-generic: remove superfluous DPRINTF avoid to break compiling
2014-08-22 2:01 [Qemu-devel] [PATCH v2] scsi-generic: remove superfluous DPRINTF avoid to break compiling arei.gonglei
@ 2014-08-22 8:54 ` Paolo Bonzini
0 siblings, 0 replies; 2+ messages in thread
From: Paolo Bonzini @ 2014-08-22 8:54 UTC (permalink / raw)
To: arei.gonglei, qemu-devel; +Cc: weidong.huang
Il 22/08/2014 04:01, arei.gonglei@huawei.com ha scritto:
> From: Gonglei <arei.gonglei@huawei.com>
>
> variables lun and tag had been eliminated, break compiling
> when enable debug switch. Meanwhile traces provide the same
> information with this DPRINTF, so remove it.
>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> v2:
> - as Paolo's suggestion, remove the superfluous DPRINTF.
> - change patch topic and commit message.
> ---
> hw/scsi/scsi-generic.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c
> index 0b2ff90..0b352fc 100644
> --- a/hw/scsi/scsi-generic.c
> +++ b/hw/scsi/scsi-generic.c
> @@ -303,9 +303,6 @@ static int32_t scsi_send_command(SCSIRequest *req, uint8_t *cmd)
> SCSIDevice *s = r->req.dev;
> int ret;
>
> - DPRINTF("Command: lun=%d tag=0x%x len %zd data=0x%02x", lun, tag,
> - r->req.cmd.xfer, cmd[0]);
> -
> #ifdef DEBUG_SCSI
> {
> int i;
>
Applied, thanks.
Paolo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-08-22 8:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-22 2:01 [Qemu-devel] [PATCH v2] scsi-generic: remove superfluous DPRINTF avoid to break compiling arei.gonglei
2014-08-22 8:54 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).