From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35886)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XKkcj-0005Qk-Kc
	for qemu-devel@nongnu.org; Fri, 22 Aug 2014 04:55:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XKkce-0002Z2-Rl
	for qemu-devel@nongnu.org; Fri, 22 Aug 2014 04:55:05 -0400
Received: from mx1.redhat.com ([209.132.183.28]:4360)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XKkce-0002Yx-KB
	for qemu-devel@nongnu.org; Fri, 22 Aug 2014 04:55:00 -0400
Message-ID: <53F70549.6070705@redhat.com>
Date: Fri, 22 Aug 2014 10:54:33 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1408672910-880-1-git-send-email-arei.gonglei@huawei.com>
In-Reply-To: <1408672910-880-1-git-send-email-arei.gonglei@huawei.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] scsi-generic: remove superfluous
 DPRINTF avoid to break compiling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: arei.gonglei@huawei.com, qemu-devel@nongnu.org
Cc: weidong.huang@huawei.com

Il 22/08/2014 04:01, arei.gonglei@huawei.com ha scritto:
> From: Gonglei <arei.gonglei@huawei.com>
> 
> variables lun and tag had been eliminated, break compiling
> when enable debug switch. Meanwhile traces provide the same
> information with this DPRINTF, so remove it.
> 
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> ---
> v2: 
>  - as Paolo's suggestion, remove the superfluous DPRINTF.
>  - change patch topic and commit message.
> ---
>  hw/scsi/scsi-generic.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/hw/scsi/scsi-generic.c b/hw/scsi/scsi-generic.c
> index 0b2ff90..0b352fc 100644
> --- a/hw/scsi/scsi-generic.c
> +++ b/hw/scsi/scsi-generic.c
> @@ -303,9 +303,6 @@ static int32_t scsi_send_command(SCSIRequest *req, uint8_t *cmd)
>      SCSIDevice *s = r->req.dev;
>      int ret;
>  
> -    DPRINTF("Command: lun=%d tag=0x%x len %zd data=0x%02x", lun, tag,
> -            r->req.cmd.xfer, cmd[0]);
> -
>  #ifdef DEBUG_SCSI
>      {
>          int i;
> 

Applied, thanks.

Paolo