From: "Andreas Färber" <afaerber@suse.de>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH qom v4 0/2] Arrayify QOM properties.
Date: Fri, 22 Aug 2014 16:24:52 +0200 [thread overview]
Message-ID: <53F752B4.8080503@suse.de> (raw)
In-Reply-To: <cover.1408517666.git.peter.crosthwaite@xilinx.com>
Am 20.08.2014 08:55, schrieb Peter Crosthwaite:
> Resending with addition of this cover letter (for those who rely
> on patches tool for series review).
>
> Changed since v3:
> Added cover letter.
>
> Regards,
> Peter
>
>
>
> Peter Crosthwaite (2):
> qom: object_property_add: Add automatic arrayification
> memory: remove object_property_add_child_array
>
> memory.c | 30 +++++-------------------------
> qom/object.c | 21 +++++++++++++++++++++
> 2 files changed, 26 insertions(+), 25 deletions(-)
I noticed that 1/2 is merely a code movement from 2/2, so my criticism
of the "calling convention" can be addressed later. Applied, thanks.
https://github.com/afaerber/qemu-cpu/commits/qom-next
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2014-08-22 14:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 6:55 [Qemu-devel] [PATCH qom v4 0/2] Arrayify QOM properties Peter Crosthwaite
2014-08-20 6:55 ` [Qemu-devel] [PATCH qom v4 1/2] qom: object_property_add: Add automatic arrayification Peter Crosthwaite
2014-08-20 6:56 ` [Qemu-devel] [PATCH qom v4 2/2] memory: remove object_property_add_child_array Peter Crosthwaite
2014-08-22 14:24 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F752B4.8080503@suse.de \
--to=afaerber@suse.de \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).