From: Eric Blake <eblake@redhat.com>
To: "Max Reitz" <mreitz@redhat.com>,
"Benoît Canet" <benoit.canet@nodalink.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/9] qcow2: Factor out refcount accounting for check
Date: Fri, 22 Aug 2014 09:48:16 -0600 [thread overview]
Message-ID: <53F76640.7040507@redhat.com> (raw)
In-Reply-To: <53F76566.2040003@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
On 08/22/2014 09:44 AM, Max Reitz wrote:
> This is not a consequence of the extracted functions moving up, but
> because of check_refblocks() preceding calculate_refcounts(). Splitting
> the check won't help; and I know that Eric dislikes
> (forward-)declarations of static functions (which I have to do if I pull
> calculate_refcounts() before check_refblocks()).
I may not like them in the end result, but they are perfectly fine for
an intermediate patch that is refactoring things, when coupled with a
followup patch that moves the refactored code into topological order.
Anything we can do to make reviewing easier, even if it requires going
through more commits and more lines of churn to get there, pays off in
the long run.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-08-22 15:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-15 15:16 [Qemu-devel] [PATCH v2 0/9] qcow2: Fix image repairing Max Reitz
2014-08-15 15:16 ` [Qemu-devel] [PATCH v2 1/9] qcow2: Fix leaks in dirty images Max Reitz
2014-08-22 16:09 ` Eric Blake
2014-08-15 15:16 ` [Qemu-devel] [PATCH v2 2/9] qcow2: Factor out refcount accounting for check Max Reitz
2014-08-21 18:47 ` Benoît Canet
2014-08-21 18:57 ` Benoît Canet
2014-08-21 19:13 ` Eric Blake
2014-08-21 21:16 ` Benoît Canet
2014-08-22 15:26 ` Max Reitz
2014-08-22 15:37 ` Benoît Canet
2014-08-22 15:44 ` Max Reitz
2014-08-22 15:46 ` Max Reitz
2014-08-22 15:48 ` Eric Blake [this message]
2014-08-15 15:16 ` [Qemu-devel] [PATCH v2 3/9] qcow2: Factor out refcount comparison " Max Reitz
2014-08-15 15:16 ` [Qemu-devel] [PATCH v2 4/9] qcow2: Fix refcount blocks beyond image end Max Reitz
2014-08-15 15:16 ` [Qemu-devel] [PATCH v2 5/9] qcow2: Do not perform potentially damaging repairs Max Reitz
2014-08-15 15:16 ` [Qemu-devel] [PATCH v2 6/9] qcow2: Rebuild refcount structure during check Max Reitz
2014-08-15 15:16 ` [Qemu-devel] [PATCH v2 7/9] qcow2: Clean up after refcount rebuild Max Reitz
2014-08-15 15:16 ` [Qemu-devel] [PATCH v2 8/9] iotests: Fix test outputs Max Reitz
2014-08-15 15:16 ` [Qemu-devel] [PATCH v2 9/9] iotests: Add test for potentially damaging repairs Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F76640.7040507@redhat.com \
--to=eblake@redhat.com \
--cc=benoit.canet@nodalink.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).