From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60721) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKr4l-0006vq-Ac for qemu-devel@nongnu.org; Fri, 22 Aug 2014 11:48:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKr4g-00073Z-Cp for qemu-devel@nongnu.org; Fri, 22 Aug 2014 11:48:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2725) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKr4g-00073T-4S for qemu-devel@nongnu.org; Fri, 22 Aug 2014 11:48:22 -0400 Message-ID: <53F76640.7040507@redhat.com> Date: Fri, 22 Aug 2014 09:48:16 -0600 From: Eric Blake MIME-Version: 1.0 References: <1408115786-13640-1-git-send-email-mreitz@redhat.com> <1408115786-13640-3-git-send-email-mreitz@redhat.com> <20140821185737.GB15636@nodalink.com> <53F644D0.2020701@redhat.com> <20140821211607.GC15636@nodalink.com> <53F76135.4010703@redhat.com> <20140822153729.GA9526@nodalink.com> <53F76566.2040003@redhat.com> In-Reply-To: <53F76566.2040003@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nMxHRKA0QH9kQPFeSrLbC9H9Am51iBtKg" Subject: Re: [Qemu-devel] [PATCH v2 2/9] qcow2: Factor out refcount accounting for check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , =?UTF-8?B?QmVub8OudCBDYW5ldA==?= Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nMxHRKA0QH9kQPFeSrLbC9H9Am51iBtKg Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/22/2014 09:44 AM, Max Reitz wrote: > This is not a consequence of the extracted functions moving up, but > because of check_refblocks() preceding calculate_refcounts(). Splitting= > the check won't help; and I know that Eric dislikes > (forward-)declarations of static functions (which I have to do if I pul= l > calculate_refcounts() before check_refblocks()). I may not like them in the end result, but they are perfectly fine for an intermediate patch that is refactoring things, when coupled with a followup patch that moves the refactored code into topological order. Anything we can do to make reviewing easier, even if it requires going through more commits and more lines of churn to get there, pays off in the long run. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --nMxHRKA0QH9kQPFeSrLbC9H9Am51iBtKg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT92ZAAAoJEKeha0olJ0Nqa4MIAJOStUPg3SCPpefv/GKUDxEX 5dSk3ZU5y/CaOXkdnNjR1Mtyx9DzdZhYGBqJu1jJQ/ijo1keZ7IKjsRCJNK64sBK zyIL4I0kJ//yiNvHxrK9gcM8rDIrQTAJMC6M7c/+zZTN4DUSnQ7UP5wkDZFM2CAZ oKJDEfeDYiMbTyJKbFriGw5HHTojaM6BrE5KhraAdvKKPUJfisSm0bjMnmG+tS0O qazKxgR9LOuJVE/qM4ECYsIwl3LFrGiX1XgrEXZQCxVapJJJEys/A0FvWj5Gx5Aa /z/V9VfGj/FOj2lyFzX3t01HGX+fF6ylJmLyR1Ih3NmsDuN5vYSNLIkEVh5mZNo= =vW8u -----END PGP SIGNATURE----- --nMxHRKA0QH9kQPFeSrLbC9H9Am51iBtKg--