From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37621) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKrPD-00063p-Hu for qemu-devel@nongnu.org; Fri, 22 Aug 2014 12:09:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKrP9-0005RF-4B for qemu-devel@nongnu.org; Fri, 22 Aug 2014 12:09:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40336) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKrP8-0005RB-SW for qemu-devel@nongnu.org; Fri, 22 Aug 2014 12:09:31 -0400 Message-ID: <53F76B36.9060506@redhat.com> Date: Fri, 22 Aug 2014 10:09:26 -0600 From: Eric Blake MIME-Version: 1.0 References: <1408115786-13640-1-git-send-email-mreitz@redhat.com> <1408115786-13640-2-git-send-email-mreitz@redhat.com> In-Reply-To: <1408115786-13640-2-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5XWevTMoGOFIiX5BlNKos6bvsTjgbbxeJ" Subject: Re: [Qemu-devel] [PATCH v2 1/9] qcow2: Fix leaks in dirty images List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi , =?UTF-8?B?QmVub8OudCBDYW5ldA==?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5XWevTMoGOFIiX5BlNKos6bvsTjgbbxeJ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/15/2014 09:16 AM, Max Reitz wrote: > When opening dirty images, qcow2's repair function should not only > repair errors but leaks as well. >=20 > Signed-off-by: Max Reitz > --- > block/qcow2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake >=20 > diff --git a/block/qcow2.c b/block/qcow2.c > index 435e0e1..8faa75d 100644 > --- a/block/qcow2.c > +++ b/block/qcow2.c > @@ -790,7 +790,7 @@ static int qcow2_open(BlockDriverState *bs, QDict *= options, int flags, > (s->incompatible_features & QCOW2_INCOMPAT_DIRTY)) { > BdrvCheckResult result =3D {0}; > =20 > - ret =3D qcow2_check(bs, &result, BDRV_FIX_ERRORS); > + ret =3D qcow2_check(bs, &result, BDRV_FIX_ERRORS | BDRV_FIX_LE= AKS); > if (ret < 0) { > error_setg_errno(errp, -ret, "Could not repair dirty image= "); > goto fail; >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --5XWevTMoGOFIiX5BlNKos6bvsTjgbbxeJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT92s2AAoJEKeha0olJ0NqfEYIAJYVjFk9XfeGKSIUXDzWVx5w FL6iusZDSzzt2BDXJT66T3QVQifM85F7ijD40PoovlpvZOowEAQ9FTeUInjYpUod 8J0EVXrSBcF8m7fJelKxzxGDdcDEVYVdJvWEM1j2UMOw4da2WCoEfnscS+itHcPq Kuq5QPyn513Ux9Xs7lsKu0W8bkRkL61G0nZ5QV2pJHEIUAuDzmsUl1JArdoxdVBc zvA+4dXCrzRYkrJwImaUR1wRIatKY7ymb5j4xHWnwtsyFmpVqVuEymGK8NEEAH+l X7iMuV8x/4gaKim0/izEA40FTA8wzvCYXRBMAumA3t70nDzuTGRJtEWcrNbFNYw= =FVRN -----END PGP SIGNATURE----- --5XWevTMoGOFIiX5BlNKos6bvsTjgbbxeJ--