From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57726) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKqop-0003GH-7n for qemu-devel@nongnu.org; Fri, 22 Aug 2014 11:32:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKqoi-0002Dy-VL for qemu-devel@nongnu.org; Fri, 22 Aug 2014 11:31:59 -0400 Received: from mail.uni-paderborn.de ([131.234.142.9]:19186) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKqoi-0002Dr-Oo for qemu-devel@nongnu.org; Fri, 22 Aug 2014 11:31:52 -0400 Message-ID: <53F77165.9050409@mail.uni-paderborn.de> Date: Fri, 22 Aug 2014 17:35:49 +0100 From: Bastian Koppelmann MIME-Version: 1.0 References: <1407931644-25602-1-git-send-email-kbastian@mail.uni-paderborn.de> <1407931644-25602-16-git-send-email-kbastian@mail.uni-paderborn.de> <53F65B0A.9070609@twiddle.net> In-Reply-To: <53F65B0A.9070609@twiddle.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 15/15] target-tricore: Add instructions of SR opcode format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-devel@nongnu.org Cc: blauwirbel@gmail.com, peter.maydell@linaro.org On 08/21/2014 09:48 PM, Richard Henderson wrote: > On 08/13/2014 05:07 AM, Bastian Koppelmann wrote: >> +/* SR-format */ >> + case OPCM_16_SR_SYSTEM: >> + decode_sr_system(env, ctx); >> + break; >> + case OPCM_16_SR_ACCU: >> + decode_sr_accu(env, ctx); >> + break; > Formatting is off; checkpatch should have caught this. > I ran checkpatch again and oddly it does not find that error, so I've put Blue Swirl into cc. > r~ >