From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45940) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKuoU-0005cJ-Fa for qemu-devel@nongnu.org; Fri, 22 Aug 2014 15:47:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XKuoP-00030P-HU for qemu-devel@nongnu.org; Fri, 22 Aug 2014 15:47:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47892) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XKuoP-0002zr-AG for qemu-devel@nongnu.org; Fri, 22 Aug 2014 15:47:49 -0400 Message-ID: <53F79E60.6010506@redhat.com> Date: Fri, 22 Aug 2014 13:47:44 -0600 From: Eric Blake MIME-Version: 1.0 References: <20140821175235.12061.22630.stgit@fimbulvetr.bsc.es> <53F763CD.7080202@redhat.com> <8738coo0et.fsf@fimbulvetr.bsc.es> In-Reply-To: <8738coo0et.fsf@fimbulvetr.bsc.es> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0U37GpiL1jMBnlbCiv0u9s6ll588DjjUM" Subject: Re: [Qemu-devel] [PATCH v3] trace: [qmp] Add QAPI/QMP commands to query and control event tracing state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Stefan Hajnoczi , Luiz Capitulino , Markus Armbruster , Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --0U37GpiL1jMBnlbCiv0u9s6ll588DjjUM Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/22/2014 12:16 PM, Llu=C3=ADs Vilanova wrote: >>> +# @name: Event name. >>> +# @sstatic: Static tracing state. >>> +# @sdynamic: Dynamic tracing state. >=20 >> Does the leading 's' add any value? QAPI doesn't have to use obscure >> abbreviations. >=20 > It felt wrong to have a JSON attribute named differently from the C str= uct > (static is a reserved word). The qapi generator will automatically convert 'static' in QMP to q_static in C code. I'd rather the QMP looks clean, even if the underlying C code has to deal with a munged name. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --0U37GpiL1jMBnlbCiv0u9s6ll588DjjUM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT955gAAoJEKeha0olJ0NqwM8IAJUw+7LTa/0JG+VEcFO47NbY p7StnU/57+Hx8rIt4R/trvIWFYB9CE+Oo0tXS5bhYVBLW6AOk8YK1ihQspNFtnVG l2n+Xnx4+XQ0/bO1oIALFgWAOKwmj8GNBbfYo2Lp9dhzXlywTbgcvA0BmL58HgYZ o/i1nMCD6tvEzNZ+uErtv8kuZ8tVnz25Qpq7ZkKcuOETH7uTufOAdhQVbItmWHw1 5QzO18eovYzAT+HTcsAbS88Lc1s8nD87LhQf/9KXW9If38jNfTwpDMf5Vi3vjCOv 7Tdbom/7iJL6twUWozFbeBMS/6xL2CWd0LHcDhOoPR7GaYn7JviYNOXubzb+WRc= =Q+7B -----END PGP SIGNATURE----- --0U37GpiL1jMBnlbCiv0u9s6ll588DjjUM--