From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Benoît Canet" <benoit.canet@nodalink.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 10/10] iotests: Add test for potentially damaging repairs
Date: Fri, 22 Aug 2014 13:55:01 -0600 [thread overview]
Message-ID: <53F7A015.5000004@redhat.com> (raw)
In-Reply-To: <1408725104-17176-11-git-send-email-mreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]
On 08/22/2014 10:31 AM, Max Reitz wrote:
> There are certain cases where repairing a qcow2 image might actually
> damage it further (or rather, where repairing it has in fact damaged it
> further with the old qcow2 check implementation). This should not
> happen, so add a test for these cases.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/104 | 98 ++++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/104.out | 46 ++++++++++++++++++++++
> tests/qemu-iotests/group | 1 +
> 3 files changed, 145 insertions(+)
> create mode 100755 tests/qemu-iotests/104
> create mode 100644 tests/qemu-iotests/104.out
>
> diff --git a/tests/qemu-iotests/104 b/tests/qemu-iotests/104
> new file mode 100755
> index 0000000..cc6d0b3
> --- /dev/null
> +++ b/tests/qemu-iotests/104
> @@ -0,0 +1,98 @@
> +#!/bin/bash
> +#
> +# Test case for repairing qcow2 images which cannot be repaired using
> +# the on-disk refcount structures
> +#
> +# Copyright (C) 2013 Red Hat, Inc.
Welcome to 2014, where we are practically 2/3 through with the year
already :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-08-22 19:55 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 16:31 [Qemu-devel] [PATCH v3 00/10] qcow2: Fix image repairing Max Reitz
2014-08-22 16:31 ` [Qemu-devel] [PATCH v3 01/10] qcow2: Fix leaks in dirty images Max Reitz
2014-08-22 18:44 ` Benoît Canet
2014-08-22 16:31 ` [Qemu-devel] [PATCH v3 02/10] qcow2: Split qcow2_check_refcounts() Max Reitz
2014-08-22 18:03 ` Benoît Canet
2014-08-22 16:31 ` [Qemu-devel] [PATCH v3 03/10] qcow2: Pull check_refblocks() up Max Reitz
2014-08-22 18:04 ` Benoît Canet
2014-08-22 16:31 ` [Qemu-devel] [PATCH v3 04/10] qcow2: Reuse refcount table in calculate_refcounts() Max Reitz
2014-08-22 18:07 ` Benoît Canet
2014-08-22 16:31 ` [Qemu-devel] [PATCH v3 05/10] qcow2: Fix refcount blocks beyond image end Max Reitz
2014-08-22 18:20 ` Benoît Canet
2014-08-26 13:07 ` Eric Blake
2014-08-26 18:06 ` Max Reitz
2014-08-22 16:31 ` [Qemu-devel] [PATCH v3 06/10] qcow2: Do not perform potentially damaging repairs Max Reitz
2014-08-22 18:25 ` Benoît Canet
2014-08-22 16:31 ` [Qemu-devel] [PATCH v3 07/10] qcow2: Rebuild refcount structure during check Max Reitz
2014-08-25 17:40 ` Benoît Canet
2014-08-27 18:37 ` Max Reitz
2014-08-22 16:31 ` [Qemu-devel] [PATCH v3 08/10] qcow2: Clean up after refcount rebuild Max Reitz
2014-08-22 18:43 ` Benoît Canet
2014-08-22 16:31 ` [Qemu-devel] [PATCH v3 09/10] iotests: Fix test outputs Max Reitz
2014-08-26 13:09 ` Eric Blake
2014-08-26 18:03 ` Max Reitz
2014-08-22 16:31 ` [Qemu-devel] [PATCH v3 10/10] iotests: Add test for potentially damaging repairs Max Reitz
2014-08-22 18:50 ` Benoît Canet
2014-08-22 19:55 ` Eric Blake [this message]
2014-08-22 20:55 ` Benoît Canet
2014-08-26 17:53 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F7A015.5000004@redhat.com \
--to=eblake@redhat.com \
--cc=benoit.canet@nodalink.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).