From: Michael Tokarev <mjt@tls.msk.ru>
To: Dmitry Fleytman <dmitry@daynix.com>
Cc: qemu-trivial@nongnu.org, Tamir Shomer <tamirs@daynix.com>,
qemu-devel@nongnu.org, Ben Draper <ben@xrsa.net>,
Stefan Hajnoczi <stefanha@redhat.com>,
Yan Vugenfirer <yan@daynix.com>
Subject: Re: [Qemu-devel] [PATCH] vmxnet3: Pad short frames to minimum size (60 bytes)
Date: Sun, 24 Aug 2014 17:10:21 +0400 [thread overview]
Message-ID: <53F9E43D.2020103@msgid.tls.msk.ru> (raw)
In-Reply-To: <A9C9B9DB-AEEE-4D79-A968-E0F34671C865@daynix.com>
24.08.2014 16:28, Dmitry Fleytman wrote:
> Hi Michael,
>
> I’m the maintainer of vmxnet3/pvscsi devices in QEMU. Thanks for CC’ing me.
Maybe you can add yourself to MAINTAINERS file as well? :)
I dunno if that's actually needed, but at least this should
stop "strain" patches like this to be sent to -trivial alone... ;)
> I think this patch is correct and needed.
>
> As we saw a few times already on different operating systems,
> vmware drivers expect short packets to be padded as required
> by corresponding RFC. Therefore this patch fixes a real bug.
Okay, since there's no entry for vmxnet in MAINTAINERS, and with
your blessing, and since this is a rather specific device which
is not in common use, I'll apply it to -trivial, for now, unless
you want to pick it up and send a pull request for it.
Given your description, I think it should be Cc: qemu-stable@.
> Reviewed-by: Dmitry Fleytman <dmitry@daynix.com>
Thanks,
/mjt
next prev parent reply other threads:[~2014-08-24 13:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 12:27 [Qemu-devel] [PATCH] vmxnet3: Pad short frames to minimum size (60 bytes) Ben Draper
2014-08-22 10:23 ` Ben Draper
2014-08-24 12:06 ` Michael Tokarev
2014-08-24 12:28 ` Dmitry Fleytman
2014-08-24 13:10 ` Michael Tokarev [this message]
2014-08-24 13:27 ` Dmitry Fleytman
2014-08-25 7:41 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F9E43D.2020103@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=ben@xrsa.net \
--cc=dmitry@daynix.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
--cc=tamirs@daynix.com \
--cc=yan@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).