From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, Peter Lieven <pl@kamp.de>
Cc: benoit.canet@irqsave.net, maxa@catit.be, qemu-devel@nongnu.org,
stefanha@redhat.com
Subject: Re: [Qemu-devel] [Fwd: [PATCH v4 07/21] iscsi: Handle failure for potentially large allocations]
Date: Sun, 24 Aug 2014 18:30:31 +0200 [thread overview]
Message-ID: <53FA1327.5020808@redhat.com> (raw)
In-Reply-To: <20140822084246.GA32377@noname.redhat.com>
Il 22/08/2014 10:42, Kevin Wolf ha scritto:
> > Unfortunately, I missed that one. The zeroblock is typicalls 512 Byte or 4K depending
> > on the blocksize.
>
> I don't remember the details, but I think when I went through all
> drivers, I couldn't convince myself that a reasonable block size is
> enforced somewhere. So I just went ahead and converted the call to be on
> the safe side. It can never hurt anyway.
Yeah, a malicious iSCSI target could have unreasonable block sizes.
This means the minimum transfer size for SCSI devices could be on the
order of half a GiB, and that could cause other unbounded allocations in
the read-modify-write code. Are those protected too?
Paolo
next prev parent reply other threads:[~2014-08-24 16:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <00c425bd67fc66567dc683205f8f60f7.squirrel@ssl.dlhnet.de>
2014-08-22 7:40 ` [Qemu-devel] [Fwd: [PATCH v4 07/21] iscsi: Handle failure for potentially large allocations] Peter Lieven
2014-08-22 8:42 ` Kevin Wolf
2014-08-22 8:59 ` Peter Lieven
2014-08-24 16:30 ` Paolo Bonzini [this message]
2014-08-24 19:31 ` Peter Lieven
2014-08-25 8:56 ` Paolo Bonzini
2014-08-25 9:56 ` Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FA1327.5020808@redhat.com \
--to=pbonzini@redhat.com \
--cc=benoit.canet@irqsave.net \
--cc=kwolf@redhat.com \
--cc=maxa@catit.be \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).