From: Jun Li <junmuzi@gmail.com>
To: kwolf@redhat.com, stefanha@redhat.com
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] qcow2: Add bdrv_discard support
Date: Mon, 25 Aug 2014 00:38:06 +0800 [thread overview]
Message-ID: <53FA14EE.2060104@gmail.com> (raw)
Hi Kevin and Stefan,
As the realize of bdrv_discard, and this patch has been received, but
I have some question.
This adds a bdrv_discard function to qcow2 that frees the discarded clusters.
It does not yet pass the discard on to the underlying file system driver, but
the space can be reused by future writes to the image.
Above content is on url:
https://lists.gnu.org/archive/html/qemu-devel/2011-01/msg03100.html
I have following question:
Why bdrv_discard does not yet pass the discard on to the underlying file
system driver? And this exist a potential issue: host cluster leak for
qcow2. As qcow2 image can be created on RAW disk,
so this is not just "does not yet pass the discard on to the underlying
file system driver". Could you give some explanation why do not realize
this function? Thx.
As I am trying to realize qcow2 shrinking, but hit bdrv_discard can not
release the free cluster on host.
Best Regards,
Jun Li
next reply other threads:[~2014-08-24 16:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-24 16:38 Jun Li [this message]
2014-08-27 14:12 ` [Qemu-devel] [PATCH v2] qcow2: Add bdrv_discard support Stefan Hajnoczi
-- strict thread matches above, loose matches on Subject: below --
2011-01-28 11:41 Kevin Wolf
2011-01-28 12:46 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FA14EE.2060104@gmail.com \
--to=junmuzi@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).