qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Lieven <pl@kamp.de>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/2] block/iscsi: handle failure on malloc of the allocationmap
Date: Mon, 25 Aug 2014 13:42:05 +0200	[thread overview]
Message-ID: <53FB210D.7050703@redhat.com> (raw)
In-Reply-To: <53FB1D4D.4070505@kamp.de>

Il 25/08/2014 13:26, Peter Lieven ha scritto:
>>>
>> Hmm, good question.  If so, the patch is correct with error_report.  I
>> thought a failure in iscsi_open would be less surprising.  The question
>> then is, do we need an option to disable allocationmap queries?
> 
> We have cache=none...

Doh, right.  Then I think iscsi_open should fail if it cannot allocate
the map.

Paolo

      reply	other threads:[~2014-08-25 11:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-22  9:26 [Qemu-devel] [PATCH 0/2] introduce bitmap_try_new Peter Lieven
2014-08-22  9:26 ` [Qemu-devel] [PATCH 1/2] util: " Peter Lieven
2014-08-25 15:09   ` Eric Blake
2014-09-05 20:00     ` Peter Lieven
2014-09-05 22:17       ` Eric Blake
2014-08-22  9:26 ` [Qemu-devel] [PATCH 2/2] block/iscsi: handle failure on malloc of the allocationmap Peter Lieven
2014-08-25 10:37   ` Paolo Bonzini
2014-08-25 11:10     ` Peter Lieven
2014-08-25 11:20       ` Paolo Bonzini
2014-08-25 11:26         ` Peter Lieven
2014-08-25 11:42           ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53FB210D.7050703@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pl@kamp.de \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).