From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35407) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XLsfI-0005yi-AE for qemu-devel@nongnu.org; Mon, 25 Aug 2014 07:42:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XLsfA-0002nB-R6 for qemu-devel@nongnu.org; Mon, 25 Aug 2014 07:42:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32749) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XLsfA-0002mr-J6 for qemu-devel@nongnu.org; Mon, 25 Aug 2014 07:42:16 -0400 Message-ID: <53FB210D.7050703@redhat.com> Date: Mon, 25 Aug 2014 13:42:05 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1408699567-6940-1-git-send-email-pl@kamp.de> <1408699567-6940-3-git-send-email-pl@kamp.de> <53FB11FB.7090703@redhat.com> <53FB19BD.1000508@kamp.de> <53FB1C05.3040801@redhat.com> <53FB1D4D.4070505@kamp.de> In-Reply-To: <53FB1D4D.4070505@kamp.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] block/iscsi: handle failure on malloc of the allocationmap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com Il 25/08/2014 13:26, Peter Lieven ha scritto: >>> >> Hmm, good question. If so, the patch is correct with error_report. I >> thought a failure in iscsi_open would be less surprising. The question >> then is, do we need an option to disable allocationmap queries? > > We have cache=none... Doh, right. Then I think iscsi_open should fail if it cannot allocate the map. Paolo