qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org
Cc: lersek@redhat.com, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 0/3] Sync MTRRs with KVM and disable on reset
Date: Mon, 25 Aug 2014 18:49:55 +0200	[thread overview]
Message-ID: <53FB6933.7000007@redhat.com> (raw)
In-Reply-To: <20140814213751.16881.91600.stgit@gimli.home>

Il 14/08/2014 23:39, Alex Williamson ha scritto:
> v3:
>  - Fix off-by-one identified by Laszlo in 2/3
>  - Add R-b in 1 & 3
> 
> It turns out that not only do we not follow the SDM guidelines for
> reseting MTRR state on vCPU reset, but we really don't even attempt
> to keep KVM MTRR state synchronized with QEMU, which affects not
> only reset, but migration.  This series implements the get/put MSR
> support for KVM, then goes on to properly re-initialize the state on
> vCPU reset.  This resolves the problem described in the last patch
> as well as some potential mismatches around migration.  The migration
> state is unchanged, other than actually passing valid data.
> 
> Thanks to Laszlo for his help debugging this and realization of how
> terribly broken MTRR synchronization is.  Thanks,

Applying to uq/master, thanks.

Paolo

      parent reply	other threads:[~2014-08-25 16:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-14 21:39 [Qemu-devel] [PATCH v3 0/3] Sync MTRRs with KVM and disable on reset Alex Williamson
2014-08-14 21:39 ` [Qemu-devel] [PATCH v3 1/3] x86: Use common variable range MTRR counts Alex Williamson
2014-08-14 21:39 ` [Qemu-devel] [PATCH v3 2/3] x86: kvm: Add MTRR support for kvm_get|put_msrs() Alex Williamson
2014-08-14 22:18   ` Laszlo Ersek
2014-08-14 21:39 ` [Qemu-devel] [PATCH v3 3/3] x86: Clear MTRRs on vCPU reset Alex Williamson
2014-08-25 16:49 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53FB6933.7000007@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=lersek@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).