From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41238) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XLxTC-0002e1-0B for qemu-devel@nongnu.org; Mon, 25 Aug 2014 12:50:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XLxT2-0004A5-Dk for qemu-devel@nongnu.org; Mon, 25 Aug 2014 12:50:13 -0400 Sender: Paolo Bonzini Message-ID: <53FB6933.7000007@redhat.com> Date: Mon, 25 Aug 2014 18:49:55 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20140814213751.16881.91600.stgit@gimli.home> In-Reply-To: <20140814213751.16881.91600.stgit@gimli.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/3] Sync MTRRs with KVM and disable on reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson , qemu-devel@nongnu.org, kvm@vger.kernel.org Cc: lersek@redhat.com, qemu-stable@nongnu.org Il 14/08/2014 23:39, Alex Williamson ha scritto: > v3: > - Fix off-by-one identified by Laszlo in 2/3 > - Add R-b in 1 & 3 > > It turns out that not only do we not follow the SDM guidelines for > reseting MTRR state on vCPU reset, but we really don't even attempt > to keep KVM MTRR state synchronized with QEMU, which affects not > only reset, but migration. This series implements the get/put MSR > support for KVM, then goes on to properly re-initialize the state on > vCPU reset. This resolves the problem described in the last patch > as well as some potential mismatches around migration. The migration > state is unchanged, other than actually passing valid data. > > Thanks to Laszlo for his help debugging this and realization of how > terribly broken MTRR synchronization is. Thanks, Applying to uq/master, thanks. Paolo