From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32869) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XM3eo-0003iZ-To for qemu-devel@nongnu.org; Mon, 25 Aug 2014 19:26:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XM3ek-0001n2-0B for qemu-devel@nongnu.org; Mon, 25 Aug 2014 19:26:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21232) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XM3ej-0001mx-N3 for qemu-devel@nongnu.org; Mon, 25 Aug 2014 19:26:33 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7PNQWI6019627 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 25 Aug 2014 19:26:33 -0400 Message-ID: <53FBC627.1000209@redhat.com> Date: Mon, 25 Aug 2014 17:26:31 -0600 From: Eric Blake MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QhraRDEFk54lesa1VL1C2Hli3iJKX4s3C" Subject: [Qemu-devel] bad error message in drive-mirror List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "qemu-devel@nongnu.org" , Markus Armbruster , Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QhraRDEFk54lesa1VL1C2Hli3iJKX4s3C Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I just noticed today that passing "granularity":1 to QMP drive-mirror results in this confusing error message: Invalid parameter 'drive-virtio-disk0' because the code mistakenly did error_set(errp, QERR_INVALID_PARAMETER, device); instead of the correct error_set(errp, QERR_INVALID_PARAMETER, "granularity"); I ran out of time to patch it today, and at any rate, whoever writes the patch should probably audit for other bad uses of error_set(QERR_INVALID_PARAMETER). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --QhraRDEFk54lesa1VL1C2Hli3iJKX4s3C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJT+8YnAAoJEKeha0olJ0NqQKIH/0MzFoY/NkLZL++C1gT+cmmc emTu74AsJXxDzvJuD+Gr9l9QXbD59Oa0RRD9d6HDgKOpWj62O2l/UmUL+Q+Rdb7Z XnkDZHZYyOduYeq1zJYykLabff4aCKgkeJx7WvLeHWUDcI73yzFRGCSB05ZZEg8p 7KDQd72Tn5IhGSY5w+hZzSNhHCNmju2Tnu49m/PpLZFsyKWGoOZ3z1o2c/vQ1Gxb 4Cz7JtF6aDr0v/SSO5rZpjJ43bykqYSqjVx5sGgeDx+XkE3SX/LuZlQo4qapt/AB oXRH5UMSdg+rSlcH6kWi3dnlzpAtnWXJcJcMU29vgrV4telpuVk9nJk6jWsdTqM= =MI/P -----END PGP SIGNATURE----- --QhraRDEFk54lesa1VL1C2Hli3iJKX4s3C--