From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMCVt-0006a2-FS for qemu-devel@nongnu.org; Tue, 26 Aug 2014 04:54:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMCVn-00007X-QC for qemu-devel@nongnu.org; Tue, 26 Aug 2014 04:54:01 -0400 Received: from mail-qg0-x231.google.com ([2607:f8b0:400d:c04::231]:50380) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMCVn-00007P-Kv for qemu-devel@nongnu.org; Tue, 26 Aug 2014 04:53:55 -0400 Received: by mail-qg0-f49.google.com with SMTP id j107so14158406qga.22 for ; Tue, 26 Aug 2014 01:53:55 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <53FC4B0D.6000906@redhat.com> Date: Tue, 26 Aug 2014 10:53:33 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20140826071427.1672.48119.stgit@PASHA-ISP> <20140826071519.1672.54843.stgit@PASHA-ISP> In-Reply-To: <20140826071519.1672.54843.stgit@PASHA-ISP> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 09/12] rtl8139: adding new fields to vmstate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk , qemu-devel@nongnu.org Cc: zealot351@gmail.com, maria.klimushenkova@ispras.ru Il 26/08/2014 09:15, Pavel Dovgalyuk ha scritto: > This patch adds virtual clock-dependent timers to VMState to allow correct > saving and restoring the state of RTL8139 network controller. > > Signed-off-by: Pavel Dovgalyuk > --- > hw/net/rtl8139.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++++-- > 1 files changed, 48 insertions(+), 2 deletions(-) Again, this is only needed in your record/replay system (and you haven't yet quite explained why the design has this limitation), so it should not be a part of this series. I'll review the other patches separately, no need to resubmit. Paolo