From: Paolo Bonzini <pbonzini@redhat.com>
To: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>, qemu-devel@nongnu.org
Cc: zealot351@gmail.com, maria.klimushenkova@ispras.ru
Subject: Re: [Qemu-devel] [PATCH 10/12] piix: do not raise irq while loading vmstate
Date: Tue, 26 Aug 2014 11:21:58 +0200 [thread overview]
Message-ID: <53FC51B6.70509@redhat.com> (raw)
In-Reply-To: <20140826071525.1672.14717.stgit@PASHA-ISP>
Il 26/08/2014 09:15, Pavel Dovgalyuk ha scritto:
> This patch disables raising an irq while loading the state of PCI bridge.
>
> Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
> ---
> hw/pci-host/piix.c | 22 ++++++++++++++++++++--
> 1 files changed, 20 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
> index e0e0946..86d6d20 100644
> --- a/hw/pci-host/piix.c
> +++ b/hw/pci-host/piix.c
> @@ -409,7 +409,7 @@ static void piix3_set_irq_pic(PIIX3State *piix3, int pic_irq)
> (pic_irq * PIIX_NUM_PIRQS))));
> }
>
> -static void piix3_set_irq_level(PIIX3State *piix3, int pirq, int level)
> +static void piix3_set_irq_level_internal(PIIX3State *piix3, int pirq, int level)
> {
> int pic_irq;
> uint64_t mask;
> @@ -422,6 +422,18 @@ static void piix3_set_irq_level(PIIX3State *piix3, int pirq, int level)
> mask = 1ULL << ((pic_irq * PIIX_NUM_PIRQS) + pirq);
> piix3->pic_levels &= ~mask;
> piix3->pic_levels |= mask * !!level;
> +}
> +
> +static void piix3_set_irq_level(PIIX3State *piix3, int pirq, int level)
> +{
> + int pic_irq;
> +
> + pic_irq = piix3->dev.config[PIIX_PIRQC + pirq];
> + if (pic_irq >= PIIX_NUM_PIC_IRQS) {
> + return;
> + }
> +
> + piix3_set_irq_level_internal(piix3, pirq, level);
>
> piix3_set_irq_pic(piix3, pic_irq);
> }
> @@ -527,7 +539,13 @@ static void piix3_reset(void *opaque)
> static int piix3_post_load(void *opaque, int version_id)
> {
> PIIX3State *piix3 = opaque;
> - piix3_update_irq_levels(piix3);
> + int pirq;
> +
> + piix3->pic_levels = 0;
> + for (pirq = 0; pirq < PIIX_NUM_PIRQS; pirq++) {
> + piix3_set_irq_level_internal(piix3, pirq,
> + pci_bus_get_irq_level(piix3->dev.bus, pirq));
> + }
> return 0;
> }
>
>
>
>
The commit message or (probably better) a comment in the code should
explain why the PIC state must not be updated, that is which side effect
is undesirable.
This would clarify whether the change is useful for migration too, or
just cosmetic outside record/replay. Unlike other patches, however, I
think this could be acceptable even without record/replay
infrastructure, because it is not going against "accepted" patterns for
migration.
Paolo
next prev parent reply other threads:[~2014-08-26 9:22 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 7:14 [Qemu-devel] [PATCH 00/12] Fixing hardware migration issues Pavel Dovgalyuk
2014-08-26 7:14 ` [Qemu-devel] [PATCH 01/12] integratorcp: adding vmstate for save/restore Pavel Dovgalyuk
2014-08-26 7:14 ` [Qemu-devel] [PATCH 02/12] pcspk: " Pavel Dovgalyuk
2014-08-26 9:10 ` Paolo Bonzini
2014-08-26 7:14 ` [Qemu-devel] [PATCH 03/12] fdc: " Pavel Dovgalyuk
2014-08-26 9:10 ` Paolo Bonzini
2014-08-26 7:14 ` [Qemu-devel] [PATCH 04/12] parallel: " Pavel Dovgalyuk
2014-08-26 9:10 ` Paolo Bonzini
2014-08-26 7:14 ` [Qemu-devel] [PATCH 05/12] serial: fixing " Pavel Dovgalyuk
2014-08-26 10:09 ` Paolo Bonzini
2014-08-26 7:15 ` [Qemu-devel] [PATCH 06/12] kvmvapic: fixing loading vmstate Pavel Dovgalyuk
2014-08-26 10:01 ` Paolo Bonzini
2014-08-27 12:16 ` Pavel Dovgaluk
2014-08-27 12:35 ` Paolo Bonzini
2014-08-27 13:03 ` Pavel Dovgaluk
2014-08-27 13:22 ` Paolo Bonzini
2014-09-09 10:30 ` Pavel Dovgaluk
2014-09-09 12:14 ` Paolo Bonzini
2014-08-26 7:15 ` [Qemu-devel] [PATCH 07/12] hpet: fixing saving and loading process Pavel Dovgalyuk
2014-08-26 7:15 ` [Qemu-devel] [PATCH 08/12] pckbd: adding new fields to vmstate Pavel Dovgalyuk
2014-08-26 9:12 ` Paolo Bonzini
2014-08-26 7:15 ` [Qemu-devel] [PATCH 09/12] rtl8139: " Pavel Dovgalyuk
2014-08-26 8:53 ` Paolo Bonzini
2014-08-27 10:15 ` Pavel Dovgaluk
2014-08-27 10:23 ` Paolo Bonzini
2014-08-27 10:30 ` Pavel Dovgaluk
2014-08-27 10:42 ` Paolo Bonzini
2014-08-27 10:48 ` Pavel Dovgaluk
[not found] ` <30591.5658282631$1409136551@news.gmane.org>
2014-08-27 15:50 ` Paolo Bonzini
2014-08-28 8:31 ` Pavel Dovgaluk
2014-08-28 11:02 ` Paolo Bonzini
2014-08-26 7:15 ` [Qemu-devel] [PATCH 10/12] piix: do not raise irq while loading vmstate Pavel Dovgalyuk
2014-08-26 9:21 ` Paolo Bonzini [this message]
2014-08-26 7:15 ` [Qemu-devel] [PATCH 11/12] mc146818rtc: add missed field to vmstate Pavel Dovgalyuk
2014-08-26 8:58 ` Paolo Bonzini
2014-08-26 7:15 ` [Qemu-devel] [PATCH 12/12] pl031: " Pavel Dovgalyuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FC51B6.70509@redhat.com \
--to=pbonzini@redhat.com \
--cc=Pavel.Dovgaluk@ispras.ru \
--cc=maria.klimushenkova@ispras.ru \
--cc=qemu-devel@nongnu.org \
--cc=zealot351@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).