From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39873)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XMKvs-00020X-Kg
	for qemu-devel@nongnu.org; Tue, 26 Aug 2014 13:53:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XMKvm-0001Fl-9v
	for qemu-devel@nongnu.org; Tue, 26 Aug 2014 13:53:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:25854)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XMKvl-0001FH-Qa
	for qemu-devel@nongnu.org; Tue, 26 Aug 2014 13:53:18 -0400
Message-ID: <53FCC982.1070000@redhat.com>
Date: Tue, 26 Aug 2014 19:53:06 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1408725104-17176-1-git-send-email-mreitz@redhat.com>
	<1408725104-17176-11-git-send-email-mreitz@redhat.com>
	<53F7A015.5000004@redhat.com>
In-Reply-To: <53F7A015.5000004@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 10/10] iotests: Add test for potentially
	damaging repairs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, =?UTF-8?B?QmVub8OudCBDYW5ldA==?= <benoit.canet@nodalink.com>, Stefan Hajnoczi <stefanha@redhat.com>

On 22.08.2014 21:55, Eric Blake wrote:
> On 08/22/2014 10:31 AM, Max Reitz wrote:
>> There are certain cases where repairing a qcow2 image might actually
>> damage it further (or rather, where repairing it has in fact damaged it
>> further with the old qcow2 check implementation). This should not
>> happen, so add a test for these cases.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>   tests/qemu-iotests/104     | 98 ++++++++++++++++++++++++++++++++++++++++++++++
>>   tests/qemu-iotests/104.out | 46 ++++++++++++++++++++++
>>   tests/qemu-iotests/group   |  1 +
>>   3 files changed, 145 insertions(+)
>>   create mode 100755 tests/qemu-iotests/104
>>   create mode 100644 tests/qemu-iotests/104.out
>>
>> diff --git a/tests/qemu-iotests/104 b/tests/qemu-iotests/104
>> new file mode 100755
>> index 0000000..cc6d0b3
>> --- /dev/null
>> +++ b/tests/qemu-iotests/104
>> @@ -0,0 +1,98 @@
>> +#!/bin/bash
>> +#
>> +# Test case for repairing qcow2 images which cannot be repaired using
>> +# the on-disk refcount structures
>> +#
>> +# Copyright (C) 2013 Red Hat, Inc.
> Welcome to 2014, where we are practically 2/3 through with the year
> already :)

Oops *g*

And I thought it was bad when I forgot which day of the week it was...

Max