From: Max Reitz <mreitz@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Benoît Canet" <benoit.canet@nodalink.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 05/10] qcow2: Fix refcount blocks beyond image end
Date: Tue, 26 Aug 2014 20:06:54 +0200 [thread overview]
Message-ID: <53FCCCBE.2030308@redhat.com> (raw)
In-Reply-To: <53FC8693.6030806@redhat.com>
On 26.08.2014 15:07, Eric Blake wrote:
> On 08/22/2014 10:31 AM, Max Reitz wrote:
>> If the qcow2 check function detects a refcount block located beyond the
>> image end, grow the image appropriately. This cannot break anything and
>> is the logical fix for such a case.
> Does the testsuite cover this one? I didn't see it mentioned in patch 10/10.
No, it doesn't. I'll add it.
Max
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>> block/qcow2-refcount.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++----
>> 1 file changed, 46 insertions(+), 4 deletions(-)
>>
next prev parent reply other threads:[~2014-08-26 18:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-22 16:31 [Qemu-devel] [PATCH v3 00/10] qcow2: Fix image repairing Max Reitz
2014-08-22 16:31 ` [Qemu-devel] [PATCH v3 01/10] qcow2: Fix leaks in dirty images Max Reitz
2014-08-22 18:44 ` Benoît Canet
2014-08-22 16:31 ` [Qemu-devel] [PATCH v3 02/10] qcow2: Split qcow2_check_refcounts() Max Reitz
2014-08-22 18:03 ` Benoît Canet
2014-08-22 16:31 ` [Qemu-devel] [PATCH v3 03/10] qcow2: Pull check_refblocks() up Max Reitz
2014-08-22 18:04 ` Benoît Canet
2014-08-22 16:31 ` [Qemu-devel] [PATCH v3 04/10] qcow2: Reuse refcount table in calculate_refcounts() Max Reitz
2014-08-22 18:07 ` Benoît Canet
2014-08-22 16:31 ` [Qemu-devel] [PATCH v3 05/10] qcow2: Fix refcount blocks beyond image end Max Reitz
2014-08-22 18:20 ` Benoît Canet
2014-08-26 13:07 ` Eric Blake
2014-08-26 18:06 ` Max Reitz [this message]
2014-08-22 16:31 ` [Qemu-devel] [PATCH v3 06/10] qcow2: Do not perform potentially damaging repairs Max Reitz
2014-08-22 18:25 ` Benoît Canet
2014-08-22 16:31 ` [Qemu-devel] [PATCH v3 07/10] qcow2: Rebuild refcount structure during check Max Reitz
2014-08-25 17:40 ` Benoît Canet
2014-08-27 18:37 ` Max Reitz
2014-08-22 16:31 ` [Qemu-devel] [PATCH v3 08/10] qcow2: Clean up after refcount rebuild Max Reitz
2014-08-22 18:43 ` Benoît Canet
2014-08-22 16:31 ` [Qemu-devel] [PATCH v3 09/10] iotests: Fix test outputs Max Reitz
2014-08-26 13:09 ` Eric Blake
2014-08-26 18:03 ` Max Reitz
2014-08-22 16:31 ` [Qemu-devel] [PATCH v3 10/10] iotests: Add test for potentially damaging repairs Max Reitz
2014-08-22 18:50 ` Benoît Canet
2014-08-22 19:55 ` Eric Blake
2014-08-22 20:55 ` Benoît Canet
2014-08-26 17:53 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FCCCBE.2030308@redhat.com \
--to=mreitz@redhat.com \
--cc=benoit.canet@nodalink.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).