From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42669) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XML9C-0007xD-Lz for qemu-devel@nongnu.org; Tue, 26 Aug 2014 14:07:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XML94-0005MB-S0 for qemu-devel@nongnu.org; Tue, 26 Aug 2014 14:07:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8115) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XML94-0005Lq-KU for qemu-devel@nongnu.org; Tue, 26 Aug 2014 14:07:02 -0400 Message-ID: <53FCCCBE.2030308@redhat.com> Date: Tue, 26 Aug 2014 20:06:54 +0200 From: Max Reitz MIME-Version: 1.0 References: <1408725104-17176-1-git-send-email-mreitz@redhat.com> <1408725104-17176-6-git-send-email-mreitz@redhat.com> <53FC8693.6030806@redhat.com> In-Reply-To: <53FC8693.6030806@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 05/10] qcow2: Fix refcount blocks beyond image end List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: Kevin Wolf , =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , Stefan Hajnoczi On 26.08.2014 15:07, Eric Blake wrote: > On 08/22/2014 10:31 AM, Max Reitz wrote: >> If the qcow2 check function detects a refcount block located beyond the >> image end, grow the image appropriately. This cannot break anything and >> is the logical fix for such a case. > Does the testsuite cover this one? I didn't see it mentioned in patch 10/10. No, it doesn't. I'll add it. Max >> Signed-off-by: Max Reitz >> --- >> block/qcow2-refcount.c | 50 ++++++++++++++++++++++++++++++++++++++++++++++---- >> 1 file changed, 46 insertions(+), 4 deletions(-) >>