From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45904) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMLVA-0007i6-QN for qemu-devel@nongnu.org; Tue, 26 Aug 2014 14:29:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XMLV2-0003RF-Fj for qemu-devel@nongnu.org; Tue, 26 Aug 2014 14:29:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19277) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XMLV2-0003RB-88 for qemu-devel@nongnu.org; Tue, 26 Aug 2014 14:29:44 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7QIThNV009523 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 26 Aug 2014 14:29:43 -0400 Message-ID: <53FCD212.2070406@redhat.com> Date: Tue, 26 Aug 2014 20:29:38 +0200 From: Max Reitz MIME-Version: 1.0 References: <1409077076-29855-1-git-send-email-stefanha@redhat.com> <1409077076-29855-2-git-send-email-stefanha@redhat.com> In-Reply-To: <1409077076-29855-2-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/3] qemu-img: fix img_commit() error return value List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , jsnow@redhat.com, Markus Armbruster On 26.08.2014 20:17, Stefan Hajnoczi wrote: > The img_commit() return value is a process exit code. Use 1 for failure > instead of -1. The other failure paths in this function already use 1. > > Signed-off-by: Stefan Hajnoczi > --- > qemu-img.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Max Reitz